Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search source] 'View details' UI action to open clusters inspector tab when request fails #167904

Closed
Tracked by #164350
nreese opened this issue Oct 3, 2023 · 1 comment · Fixed by #170790
Closed
Tracked by #164350

[search source] 'View details' UI action to open clusters inspector tab when request fails #167904

nreese opened this issue Oct 3, 2023 · 1 comment · Fixed by #170790
Assignees
@nreese
Labels
enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Oct 3, 2023 •
edited
Loading

Similar to #167098, but for failures instead of warnings.

blocked by #167099

Screenshot 2023-10-03 at 9 46 26 AM Screenshot 2023-10-03 at 9 46 45 AM
@nreese nreese added enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese self-assigned this Oct 3, 2023
@nreese nreese mentioned this issue Oct 3, 2023
Closed
10 tasks
This was referenced Nov 7, 2023
Closed
Merged
Merged
nreese added a commit that referenced this issue Nov 10, 2023
@nreese @kibanamachine
[discover] do not show old results on error (#170769)
c078b91 
Prerequisite for #167904

### Test
1. install sample web logs
2. Open discover
3. Select time range that displays results
4. Add filter
    ```
    {
      "error_query": {
        "indices": [
          {
            "error_type": "exception",
            "message": "local shard failure message 123",
            "name": "kibana_sample_data_logs"
          }
        ]
      }
    }
    ```
5. Verify discover should display `EmptyPrompt` showing error message
instead of callout with stale data.
<img width="500" alt="Screenshot 2023-11-07 at 9 23 43 AM"
src="https://github.com/elastic/kibana/assets/373691/60237f8c-dcf5-4b4a-991f-4a9f073048af">

---------

Co-authored-by: kibanamachine <[email protected]>
nreese added a commit that referenced this issue Nov 14, 2023
@nreese @kibanamachine
On search source error, show 'view details' action that opens request…
f9870c1 
… in inspector (#170790)

Closes #167904

PR updates `EsError` with `getActions` method that returns "View
details" button. Clicking "View details" opens inspector to request that
failed. PR updates Discover and maps to display EsError action.

PR does not update lens to display "View details". Chatted with
@drewdaemon and the implementation path is more involved. This will be
completed in another PR.

### Test setup
1. install sample web logs

### Test discover with EsError
1. open discover 
2. Add filter
    ```
    {
      "error_query": {
        "indices": [
          {
            "error_type": "exception",
            "message": "local shard failure message 123",
            "name": "kibana_sample_data_logs"
          }
        ]
      }
    }
    ```
3. Verify `View details` action is displayed and clicking action opens
inspector
<img width="300" alt="Screenshot 2023-11-07 at 12 53 31 PM"
src="https://github.com/elastic/kibana/assets/373691/6b43e9c8-daab-4782-876e-ded6958d15cf">

### Test search embeddable with EsError
1. create new dashboard. Add saved search from `kibana_sample_data_logs`
data view
2. Add filter
    ```
    {
      "error_query": {
        "indices": [
          {
            "error_type": "exception",
            "message": "local shard failure message 123",
            "name": "kibana_sample_data_logs"
          }
        ]
      }
    }
    ```
3. Verify `View details` action is displayed and clicking action opens
inspector
<img width="300" alt="Screenshot 2023-11-07 at 12 55 46 PM"
src="https://github.com/elastic/kibana/assets/373691/5ebe37c6-467a-4d72-89e3-21fc53f59d89">

### Test discover with PainlessError
<img width="300" alt="Screenshot 2023-11-07 at 12 52 51 PM"
src="https://github.com/elastic/kibana/assets/373691/6d17498f-657c-46e8-86e8-dde461599267">

### Test Maps error
1. create new map
2. Add `documents` layer
3. Set scaling to "limit to 10000"
4. Add filter
    ```
    {
      "error_query": {
        "indices": [
          {
            "error_type": "exception",
            "message": "local shard failure message 123",
            "name": "kibana_sample_data_logs"
          }
        ]
      }
    }
    ```
5. Verify "View details" button is displayed in maps legend in error
callout
<img width="500" alt="Screenshot 2023-11-08 at 12 07 42 PM"
src="https://github.com/elastic/kibana/assets/373691/2eb2cc41-0919-49a3-9792-fda9707973cb">

---------

Co-authored-by: kibanamachine <[email protected]>
@nreese nreese mentioned this issue Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On search source error, show 'view details' action that opens request in inspector nreese/kibana
2 participants
@nreese @elasticmachine