Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedHistogram] Redesign Buttons, Breakdown and Interval #167427

Closed
6 tasks
Tracked by #168084
kertal opened this issue Sep 27, 2023 · 4 comments · Fixed by #171638
Closed
6 tasks
Tracked by #168084

[UnifiedHistogram] Redesign Buttons, Breakdown and Interval #167427

kertal opened this issue Sep 27, 2023 · 4 comments · Fixed by #171638
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedHistogram Issues related to the Unified Histogram plugin impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Sep 27, 2023

Image

Tasks

  • All buttons above the visualization should utilize the Shared UX toolbar button styles (again, to differentiate from other priority page actions).
  • Change Breakdown should be migrated to a button selector rather than the current select element.
  • Visualization legend should no longer use dots for color representations.
  • Migrate Time Interval selection to button selector element
  • Migrate "Hide visualization" of the options menu to it's own hide/show button displayed
  • Remove options menu
@kertal kertal added the Feature:Discover Discover Application label Sep 27, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 27, 2023
@kertal kertal added Feature:UnifiedHistogram Issues related to the Unified Histogram plugin and removed needs-team Issues missing a team label labels Sep 27, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 27, 2023
@kertal kertal added enhancement New value added to drive a business result and removed needs-team Issues missing a team label labels Sep 27, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 27, 2023
@kertal kertal added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels Sep 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Sep 27, 2023
@kertal kertal added the loe:large Large Level of Effort label Sep 27, 2023
@davismcphee
Copy link
Contributor

Since Visualization options menu removed, there's no more way restore default height to visualization, so it's no longer needed?

I think this was excluded to reduce clutter after it was determined to have very low usage in FullStory. @MichaelMarcialis should be able to confirm.

We need to migrate the number of hits to the data table, since this is currently implemented in the histogram code, and can be provided by the Lens visualization, this is a bigger refactoring. If we can't do this, the design looks a bit different in the first version, since we can't used the space where the number of hits are currently being displayed

@kertal I think you had suggested possibly doing similar to the EUI data grid render functions and pass the total hits component to Discover through Unified Histogram, which seemed like a good idea IMO. This would mean Unified Histogram could still control the logic, but we could disable the top hits display and render it wherever we want in the data grid panel.

@kertal
Copy link
Member Author

kertal commented Sep 28, 2023

@davismcphee

Since Visualization options menu removed, there's no more way restore default height to visualization, so it's no longer needed?

I think this was excluded to reduce clutter after it was determined to have very low usage in FullStory. @MichaelMarcialis should be able to confirm.

Now that we have also the fieldlist width scaleable, and also there is now way to reset it, we should align this behavior IMO

@kertal I think you had suggested possibly doing similar to the EUI data grid render functions and pass the total hits component to Discover through Unified Histogram, which seemed like a good idea IMO. This would mean Unified Histogram could still control the logic, but we could disable the top hits display and render it wherever we want in the data grid panel.

I had a brief look and we can get the number of hits in Discover by e.g. dataState.data$.totalHits$.getValue().result, so I think we are already able to apply this change without much refactoring.

@MichaelMarcialis
Copy link
Contributor

Since Visualization options menu removed, there's no more way restore default height to visualization, so it's no longer needed?

I think this was excluded to reduce clutter after it was determined to have very low usage in FullStory. @MichaelMarcialis should be able to confirm.

Now that we have also the fieldlist width scaleable, and also there is now way to reset it, we should align this behavior IMO

@kertal, @davismcphee: Correct. When I last checked FullStory, the "Reset to default height" button was only used by 0.15% of unique users over the last 30 days. Considering that very low usage, the increase in discoverability we're proposing to the show/hide visualization button, and the fact that users can simply use the resize functionality at-will, I think we can confidently remove this feature to help reduce clutter.

semd pushed a commit to semd/kibana that referenced this issue Jan 12, 2024
…ontrols in histogram. (elastic#171638)

- Closes elastic#168825
- Closes elastic#171610
- Closes elastic#167427
- Partially addresses elastic#165192

## Summary

This PR moves the total hits counter closer to the grid, updates
histogram controls and introduces new panel toggle buttons for toggling
fields sidebar and histogram.

<img width="500" alt="Screenshot 2023-12-05 at 15 37 20"
src="https://github.com/elastic/kibana/assets/1415710/5b9bd771-1052-4205-849f-18c21cc299b8">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 29"
src="https://github.com/elastic/kibana/assets/1415710/e5941b27-c497-4d7e-b461-68b66931475a">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 37"
src="https://github.com/elastic/kibana/assets/1415710/97abd32e-9ff2-4d9a-b7e7-b9d6d9cf64db">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 50"
src="https://github.com/elastic/kibana/assets/1415710/10f2b4f4-ec37-41c3-b78b-78c64e14d655">
<img width="400" alt="Screenshot 2023-12-05 at 15 37 59"
src="https://github.com/elastic/kibana/assets/1415710/ef2e28b2-f6ba-4ccb-aea4-3946ba2d5839">
<img width="300" alt="Screenshot 2023-12-05 at 15 38 05"
src="https://github.com/elastic/kibana/assets/1415710/07901ede-0bcb-46a6-a398-4562189fd54f">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 38"
src="https://github.com/elastic/kibana/assets/1415710/17830115-2111-4b8f-ae40-7b5875c06879">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 56"
src="https://github.com/elastic/kibana/assets/1415710/975d475b-280b-495a-b7b7-31c7ade5f21e">
<img width="500" alt="Screenshot 2023-12-05 at 15 43 08"
src="https://github.com/elastic/kibana/assets/1415710/38b6053a-e260-48d8-9591-3f3409df2876">

## Testing

When testing, please check collapsing/expanding the fields sidebar and
histogram. Also for ES|QL mode with suggestions, legacy table, no
results and error prompt, Field Statistics tab, data views without a
time field, light/dark themes.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedHistogram Issues related to the Unified Histogram plugin impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
5 participants