Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transform health alert: use prefix with wildcard for selecting transforms #166810

Closed
rudolf opened this issue Sep 20, 2023 · 1 comment · Fixed by #204226
Closed

[ML] Transform health alert: use prefix with wildcard for selecting transforms #166810

rudolf opened this issue Sep 20, 2023 · 1 comment · Fixed by #204226
Assignees
Labels
Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Feature:Transforms ML transforms :ml Team:ML Team label for ML (also use :ml) v8.18.0

Comments

@rudolf
Copy link
Contributor

rudolf commented Sep 20, 2023

When creating a transform health alert it's possible to select all transforms with * but it's not possible to specify a pattern like kibana-alerts-*. Being able to specify a prefix with a wildcard would make it a lot easier to alert on groups of related transforms.

Screenshot 2023-09-19 at 11 36 55

@rudolf rudolf added Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Team:ML Team label for ML (also use :ml) labels Sep 20, 2023
@darnautov darnautov added the :ml label Sep 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov self-assigned this Sep 20, 2023
@darnautov darnautov added the Feature:Transforms ML transforms label Sep 20, 2023
@peteharverson peteharverson changed the title Transform health alert: use prefix with wildcard for selecting transforms [ML] Transform health alert: use prefix with wildcard for selecting transforms Sep 20, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 17, 2024
…ic#204226)

## Summary

Closes elastic#166810

- Adds wildcards support for the tranform health alerting rule.
- Populates transforms with alerting rules based on wildcard
expressions.
- Excludes `alerting_rules` from the JSON tab.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit fd98643)
kibanamachine added a commit that referenced this issue Dec 17, 2024
…204226) (#204575)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Transforms: Support wildcards in the alerting rule flyout
(#204226)](#204226)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T13:28:39Z","message":"[ML]
Transforms: Support wildcards in the alerting rule flyout
(#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds
wildcards support for the tranform health alerting rule. \r\n- Populates
transforms with alerting rules based on wildcard\r\nexpressions.\r\n-
Excludes `alerting_rules` from the JSON tab. \r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Transforms","v9.0.0","Team:ML","backport:version","v8.18.0","v8.17.1"],"title":"[ML]
Transforms: Support wildcards in the alerting rule
flyout","number":204226,"url":"https://github.com/elastic/kibana/pull/204226","mergeCommit":{"message":"[ML]
Transforms: Support wildcards in the alerting rule flyout
(#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds
wildcards support for the tranform health alerting rule. \r\n- Populates
transforms with alerting rules based on wildcard\r\nexpressions.\r\n-
Excludes `alerting_rules` from the JSON tab. \r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204226","number":204226,"mergeCommit":{"message":"[ML]
Transforms: Support wildcards in the alerting rule flyout
(#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds
wildcards support for the tranform health alerting rule. \r\n- Populates
transforms with alerting rules based on wildcard\r\nexpressions.\r\n-
Excludes `alerting_rules` from the JSON tab. \r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
darnautov added a commit to darnautov/kibana that referenced this issue Dec 18, 2024
…ic#204226)

## Summary

Closes elastic#166810

- Adds wildcards support for the tranform health alerting rule.
- Populates transforms with alerting rules based on wildcard
expressions.
- Excludes `alerting_rules` from the JSON tab.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit fd98643)

# Conflicts:
#	x-pack/plugins/transform/public/alerting/transform_health_rule_type/transform_selector_control.test.tsx
darnautov added a commit that referenced this issue Dec 18, 2024
…#204226) (#204713)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[ML] Transforms: Support wildcards in the alerting rule flyout
(#204226)](#204226)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T13:28:39Z","message":"[ML]
Transforms: Support wildcards in the alerting rule flyout
(#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds
wildcards support for the tranform health alerting rule. \r\n- Populates
transforms with alerting rules based on wildcard\r\nexpressions.\r\n-
Excludes `alerting_rules` from the JSON tab. \r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Transforms","v9.0.0","Team:ML","backport:version","v8.18.0","v8.17.1"],"number":204226,"url":"https://github.com/elastic/kibana/pull/204226","mergeCommit":{"message":"[ML]
Transforms: Support wildcards in the alerting rule flyout
(#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds
wildcards support for the tranform health alerting rule. \r\n- Populates
transforms with alerting rules based on wildcard\r\nexpressions.\r\n-
Excludes `alerting_rules` from the JSON tab. \r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204226","number":204226,"mergeCommit":{"message":"[ML]
Transforms: Support wildcards in the alerting rule flyout
(#204226)\n\n## Summary\r\n\r\n\r\nCloses #166810\r\n\r\n- Adds
wildcards support for the tranform health alerting rule. \r\n- Populates
transforms with alerting rules based on wildcard\r\nexpressions.\r\n-
Excludes `alerting_rules` from the JSON tab. \r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fd986432e896d4804ede18024ce1202c6ef77d6d"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/204575","number":204575,"state":"MERGED","mergeCommit":{"sha":"dff3cc2943ec1ea9981dab84326a6e948456cd07","message":"[8.x]
[ML] Transforms: Support wildcards in the alerting rule flyout (#204226)
(#204575)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[ML] Transforms: Support wildcards in the alerting
rule
flyout\n(#204226)](https://github.com/elastic/kibana/pull/204226)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Dima\nArnautov\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-17T13:28:39Z\",\"message\":\"[ML]\nTransforms:
Support wildcards in the alerting rule flyout\n(#204226)\\n\\n##
Summary\\r\\n\\r\\n\\r\\nCloses #166810\\r\\n\\r\\n- Adds\nwildcards
support for the tranform health alerting rule. \\r\\n-
Populates\ntransforms with alerting rules based on
wildcard\\r\\nexpressions.\\r\\n-\nExcludes `alerting_rules` from the
JSON tab. \\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] Any text added
follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[\n]\\r\\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\\r\\nwas\nadded
for features that require explanation or tutorials\\r\\n- [x]
[Unit\nor\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most
common\nscenarios\",\"sha\":\"fd986432e896d4804ede18024ce1202c6ef77d6d\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:enhancement\",\":ml\",\"Feature:Transforms\",\"v9.0.0\",\"Team:ML\",\"backport:version\",\"v8.18.0\",\"v8.17.1\"],\"title\":\"[ML]\nTransforms:
Support wildcards in the alerting
rule\nflyout\",\"number\":204226,\"url\":\"https://github.com/elastic/kibana/pull/204226\",\"mergeCommit\":{\"message\":\"[ML]\nTransforms:
Support wildcards in the alerting rule flyout\n(#204226)\\n\\n##
Summary\\r\\n\\r\\n\\r\\nCloses #166810\\r\\n\\r\\n- Adds\nwildcards
support for the tranform health alerting rule. \\r\\n-
Populates\ntransforms with alerting rules based on
wildcard\\r\\nexpressions.\\r\\n-\nExcludes `alerting_rules` from the
JSON tab. \\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] Any text added
follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[\n]\\r\\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\\r\\nwas\nadded
for features that require explanation or tutorials\\r\\n- [x]
[Unit\nor\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most
common\nscenarios\",\"sha\":\"fd986432e896d4804ede18024ce1202c6ef77d6d\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\",\"8.17\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/204226\",\"number\":204226,\"mergeCommit\":{\"message\":\"[ML]\nTransforms:
Support wildcards in the alerting rule flyout\n(#204226)\\n\\n##
Summary\\r\\n\\r\\n\\r\\nCloses #166810\\r\\n\\r\\n- Adds\nwildcards
support for the tranform health alerting rule. \\r\\n-
Populates\ntransforms with alerting rules based on
wildcard\\r\\nexpressions.\\r\\n-\nExcludes `alerting_rules` from the
JSON tab. \\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] Any text added
follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n-\n[\n]\\r\\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\\r\\nwas\nadded
for features that require explanation or tutorials\\r\\n- [x]
[Unit\nor\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most
common\nscenarios\",\"sha\":\"fd986432e896d4804ede18024ce1202c6ef77d6d\"}},{\"branch\":\"8.x\",\"label\":\"v8.18.0\",\"branchLabelMappingKey\":\"^v8.18.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.17\",\"label\":\"v8.17.1\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Dima Arnautov
<[email protected]>"}},{"branch":"8.17","label":"v8.17.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
…ic#204226)

## Summary


Closes elastic#166810

- Adds wildcards support for the tranform health alerting rule. 
- Populates transforms with alerting rules based on wildcard
expressions.
- Excludes `alerting_rules` from the JSON tab.  

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Feature:Transforms ML transforms :ml Team:ML Team label for ML (also use :ml) v8.18.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants