Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDataTable] Set row height default to using auto-fit #164285

Closed
Tracked by #168084
kertal opened this issue Aug 21, 2023 · 1 comment · Fixed by #164218
Closed
Tracked by #168084

[UnifiedDataTable] Set row height default to using auto-fit #164285

kertal opened this issue Aug 21, 2023 · 1 comment · Fixed by #164218
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Aug 21, 2023

Set the default height of the UnifiedDataTable to "Auto fit", allowing the table rows to grow to the height of their content by default.
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2023
@kertal kertal added Feature:Discover Discover Application enhancement New value added to drive a business result Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels Aug 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the loe:small Small Level of Effort label Aug 21, 2023
@kertal kertal changed the title [UnifiedDataTable] Set default height default to using auto-fit, allowing table rows to grow to the height of their content. [UnifiedDataTable] Set default height default to using auto-fit Aug 21, 2023
@kertal kertal mentioned this issue Aug 21, 2023
Merged
@kertal kertal changed the title [UnifiedDataTable] Set default height default to using auto-fit [UnifiedDataTable] Set row height default to using auto-fit Aug 21, 2023
@davismcphee davismcphee added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Sep 8, 2023
jughosta added a commit that referenced this issue Sep 12, 2023
@jughosta @kibanamachine
[Discover] Set data table row height to auto-fit by default (#164218)
0f07497 
- Closes #164285

This PR changes the default value of "rowHeight" setting to be
"Auto-fit".

<img width="600" alt="Screenshot 2023-08-17 at 19 46 03"
src="https://github.com/elastic/kibana/assets/1415710/44cc2cc6-8bbd-41a9-b34c-94a189edbd7b">

When testing, make sure to delete "discover:dataGridRowHeight" from the
browser localStorage, refresh the page and press "New" in Discover.

Partially addresses #131130 (it
can still hide "Reset" after page reload)

---------

Co-authored-by: Kibana Machine <[email protected]>
@kertal kertal mentioned this issue Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Set data table row height to auto-fit by default jughosta/kibana
4 participants
@kertal @jughosta @elasticmachine @davismcphee