Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover is not in dark mode when user profile is in dark mode #163332

Closed
bhavyarm opened this issue Aug 7, 2023 · 2 comments · Fixed by #163387
Closed

Discover is not in dark mode when user profile is in dark mode #163332

bhavyarm opened this issue Aug 7, 2023 · 2 comments · Fixed by #163387
Assignees
@jughosta
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Aug 7, 2023

Kibana version: main

Browser version: chrome latest

Serverless project: Observability

Original install method (e.g. download page, yum, from source, etc.): from QA

Describe the bug: Discover is not in dark mode when user profile is in dark mode.

Screenshot 2023-08-07 at 11 04 59 AM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release labels Aug 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Aug 7, 2023

Thx @bhavyarm confirmed also in Kibana "Classic"

Image

@kertal kertal added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. and removed Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release labels Aug 7, 2023
@jughosta jughosta self-assigned this Aug 8, 2023
@jughosta jughosta mentioned this issue Aug 8, 2023
Merged
jughosta added a commit that referenced this issue Aug 11, 2023
@jughosta @kibanamachine
[Discover] Fix dark theme issues by removing deprecated components (#…
74911b6 
…163387)

- Closes #163332

## Summary

This PR fixes dark mode issues which surfaced after
#161914 and
#163103

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Fix dark theme issues by removing deprecated components jughosta/kibana
4 participants
@kertal @jughosta @bhavyarm @elasticmachine