Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CM][Visualizations] Correct usage of CM in visualize library #163246

Closed
stratoula opened this issue Aug 7, 2023 · 1 comment · Fixed by #165485
Closed

[CM][Visualizations] Correct usage of CM in visualize library #163246

stratoula opened this issue Aug 7, 2023 · 1 comment · Fixed by #165485
Assignees
@dej611
Labels
enhancement New value added to drive a business result Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Describe the feature:

Part of #161545

In order CM in listing page to work correctly we need to:

  • Fix regular search so that it doesn't implicitly search over lens and maps, migrate visualize listing page to use mSearch
  • When updating the SO from the listing page, we should send the SO type correctly. Atm trying to update the maps/lens SOs from the listing page throws an error.
image
@stratoula stratoula added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula changed the title [CM][Visualizations] [CM][Visualizations] Correct usage of CM in visualize library Aug 7, 2023
@stratoula stratoula added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Aug 8, 2023
@dej611 dej611 assigned ppisljar and dej611 and unassigned dej611 and ppisljar Aug 22, 2023
This was referenced Aug 31, 2023
Closed
Merged
dej611 added a commit that referenced this issue Sep 13, 2023
@dej611 @stratoula
[ContentManagement] Fix Visualize List search and CRUD operations via…
01ad4c2 
… CM (#165485)

## Summary

Fix #163246

This PR fixes the CM problems within the Visualize List page leveraging
the services already in place.
The approach here is lighter than #165292 as it passes each client via
the TypesService already used to register extensions in the
Visualization scope. Also the `search` method now transparently uses the
`mSearch` if more content types are detected without leaking any
implementation detail outside the `VisualizationClient` interface.

More fixes/features:
* fixed Maps update operation definition which was missing the
`overwrite` flag
* Allow `mSearch` to accept an options object argument
* Added new helper functions to interact with the metadata flyout in
Listing page


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dej611 dej611

Labels
enhancement New value added to drive a business result Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
4 participants
@dej611 @ppisljar @elasticmachine @stratoula