-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: Firefox UI Functional Tests - Visualize.test/functional/apps/visualize/group5/_tsvb_time_series·ts - visualize app visual builder Time Series basics Clicking on the chart should create a filter for series with multiple split by terms fields one of which has formatting #162995
Comments
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
New failure: CI Build - main |
@dmlemeshko this seems similar with the one you fixed, right? |
New failure: CI Build - main |
/skip |
Flakiness is the case only in Firefox: screenshot shows that 2nd field was not selected I tried it manually in Firefox 116.0.2 and can confirm I can select aggregations, though sometimes picking an item in dropdown is not working for me, could be a click position or maybe my personal experience. I will unskip it for Chrome only since flaky-test-runner has no failures |
## Summary Related to #162995 This PR unskip TSVB tests for Chrome browser since it is proved to be stable https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836 100x passed https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835 100x passed On Firefox the flakiness is related to Terms 2nd aggregation field sometimes is not selected. I tested it manually in Firefox 116 and was able to set fields, though I have a feeling that values are not always selected on click in the drop-down. But I didn't see any errors in console. I also returned back retry for dropdown selection I removed in #161202 though flaky-test-runner proves there is no need. Let's have just to keep logic as before my PR.
## Summary Related to elastic#162995 This PR unskip TSVB tests for Chrome browser since it is proved to be stable https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836 100x passed https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835 100x passed On Firefox the flakiness is related to Terms 2nd aggregation field sometimes is not selected. I tested it manually in Firefox 116 and was able to set fields, though I have a feeling that values are not always selected on click in the drop-down. But I didn't see any errors in console. I also returned back retry for dropdown selection I removed in elastic#161202 though flaky-test-runner proves there is no need. Let's have just to keep logic as before my PR. (cherry picked from commit 072ad96)
# Backport This will backport the following commits from `main` to `8.9`: - [[FTR] unskip tsvb time series tests for Chrome (#163510)](#163510) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-10T07:17:12Z","message":"[FTR] unskip tsvb time series tests for Chrome (#163510)\n\n## Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for Chrome browser since it is proved to be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation field\r\nsometimes is not selected. I tested it manually in Firefox 116 and was\r\nable to set fields, though I have a feeling that values are not always\r\nselected on click in the drop-down. But I didn't see any errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown selection I removed in #161202\r\nthough flaky-test-runner proves there is no need. Let's have just to\r\nkeep logic as before my PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.10.0","v8.9.1"],"number":163510,"url":"https://github.com/elastic/kibana/pull/163510","mergeCommit":{"message":"[FTR] unskip tsvb time series tests for Chrome (#163510)\n\n## Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for Chrome browser since it is proved to be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation field\r\nsometimes is not selected. I tested it manually in Firefox 116 and was\r\nable to set fields, though I have a feeling that values are not always\r\nselected on click in the drop-down. But I didn't see any errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown selection I removed in #161202\r\nthough flaky-test-runner proves there is no need. Let's have just to\r\nkeep logic as before my PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163510","number":163510,"mergeCommit":{"message":"[FTR] unskip tsvb time series tests for Chrome (#163510)\n\n## Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for Chrome browser since it is proved to be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation field\r\nsometimes is not selected. I tested it manually in Firefox 116 and was\r\nable to set fields, though I have a feeling that values are not always\r\nselected on click in the drop-down. But I didn't see any errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown selection I removed in #161202\r\nthough flaky-test-runner proves there is no need. Let's have just to\r\nkeep logic as before my PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <[email protected]>
A test failed on a tracked branch
First failure: CI Build - 8.9
The text was updated successfully, but these errors were encountered: