Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/infra/hosts_view·ts - InfraOps App Metrics UI Hosts View #Single host Flyout Overview Tab should navigate to alerts #162220

Closed
kibanamachine opened this issue Jul 19, 2023 · 11 comments · Fixed by #162312
Closed

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/infra/hosts_view·ts - InfraOps App Metrics UI Hosts View #Single host Flyout Overview Tab should navigate to alerts #162220

kibanamachine opened this issue Jul 19, 2023 · 11 comments · Fixed by #162312
Assignees
@jennypavlova
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 19, 2023 •
edited
Loading

A test failed on a tracked branch

Error: timed out waiting for returned to hosts view
    at onFailure (retry_for_truthy.ts:39:13)
    at retryForSuccess (retry_for_success.ts:59:13)
    at retryForTruthy (retry_for_truthy.ts:27:3)
    at RetryService.waitForWithTimeout (retry.ts:45:5)
    at Context.<anonymous> (hosts_view.ts:330:11)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jul 19, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 19, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Jul 19, 2023

/skip

@jbudz jbudz added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jul 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 19, 2023
@kibanamachine
Copy link
Contributor Author

Skipped

main: 8fd0577

kibanamachine added a commit that referenced this issue Jul 19, 2023
@kibanamachine
skip failing test suite (#162220)
8fd0577
Ruhshan pushed a commit to Ruhshan/kibana that referenced this issue Jul 19, 2023
@kibanamachine @Ruhshan
skip failing test suite (elastic#162220)
1364145
@jennypavlova
Copy link
Member

This is an actual bug - #162240 I will enable the test once the bug is fixed.

@jennypavlova jennypavlova self-assigned this Jul 20, 2023
@jennypavlova jennypavlova mentioned this issue Jul 20, 2023
Merged
jennypavlova added a commit that referenced this issue Jul 20, 2023
@jennypavlova
[Infra UI] Alerts link in overview: required to click back 2 times to…
84fd8c0 
… go back (#162312)

Closes #162240 
Closes #162220 
Closes #162221 

## Summary

This PR fixes the navigation to the alerts page issue when the back
button is used - in this case, the user stays on the same page instead
of going back to the previous page. This issue was found on the hosts
view page after adding the 'show all' link inside the overview tab but
it exists also when you navigate from the observability overview page.

I tested also navigating using the menu, from observability overview and
hosts view, outside of observability and the navigation works fine with
the change. If there are any concerns or if I miss something I will be
happy to discuss this.

Before:


https://github.com/elastic/kibana/assets/14139027/dc9590c9-ef7e-469c-aad4-6c6f377d9bef


After:


https://github.com/elastic/kibana/assets/14139027/be3d1f9a-bd27-426d-bd6e-61f5a0a206f3
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@kibanamachine
skip failing test suite (elastic#162220)
dbac069
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@jennypavlova
[Infra UI] Alerts link in overview: required to click back 2 times to…
29eae1e 
… go back (elastic#162312)

Closes elastic#162240 
Closes elastic#162220 
Closes elastic#162221 

## Summary

This PR fixes the navigation to the alerts page issue when the back
button is used - in this case, the user stays on the same page instead
of going back to the previous page. This issue was found on the hosts
view page after adding the 'show all' link inside the overview tab but
it exists also when you navigate from the observability overview page.

I tested also navigating using the menu, from observability overview and
hosts view, outside of observability and the navigation works fine with
the change. If there are any concerns or if I miss something I will be
happy to discuss this.

Before:


https://github.com/elastic/kibana/assets/14139027/dc9590c9-ef7e-469c-aad4-6c6f377d9bef


After:


https://github.com/elastic/kibana/assets/14139027/be3d1f9a-bd27-426d-bd6e-61f5a0a206f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra UI] Alerts link in overview: required to click back 2 times to go back jennypavlova/kibana
4 participants
@jbudz @jennypavlova @elasticmachine @kibanamachine