Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] opening formula panel causes "Uncaught Error: Maximum update depth exceeded" #161885

Closed
mbondyra opened this issue Jul 13, 2023 · 1 comment · Fixed by #161886
Closed

[Lens] opening formula panel causes "Uncaught Error: Maximum update depth exceeded" #161885

mbondyra opened this issue Jul 13, 2023 · 1 comment · Fixed by #161886
Assignees
@mbondyra
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

Kibana version:
main, caused by #159638

  1. Open Lens with dev tools console visible.
  2. Open a dimension panel for Vertical axis and choose formula tab.
  3. Everything works fine, but the console shows an error thrown:
Screenshot 2023-07-13 at 17 40 04
@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jul 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@mbondyra mbondyra self-assigned this Jul 13, 2023
@mbondyra mbondyra mentioned this issue Jul 13, 2023
Merged
mbondyra added a commit that referenced this issue Jul 14, 2023
@mbondyra
[Lens] fix opening formula panel causes "Uncaught Error: Maximum upda… (
4376853 
#161886)

…te depth exceeded"

## Summary

Fixes #161885. The infinite
update loop doesn't happen as we stabilized the `defaultTheme` object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] fix opening formula panel causes "Uncaught Error: Maximum upda… mbondyra/kibana
2 participants
@mbondyra @elasticmachine