Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Discovery] Migrate all usages of EuiPage*_Deprecated #161426

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 4 comments · Fixed by #162836
Closed
Tracked by #161872

[Data Discovery] Migrate all usages of EuiPage*_Deprecated #161426

cee-chen opened this issue Jul 7, 2023 · 4 comments · Fixed by #162836
Assignees
@jughosta
Labels
deprecation_warnings EUI Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Jul 7, 2023 •
edited by kertal
Loading

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page components being permanently removed.

Your team is being pinged in this issue because you have usages of EuiPage*_Deprecated components, which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added deprecation_warnings EUI Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Jul 7, 2023

Thx for the heads up @cee-chen. Incredible how fast time passes, and it seems, since we removed those parts of Discover we didn't have those other usages on the radar. We'll discuss in the team sync

@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@davismcphee davismcphee added Feature:Discover Discover Application loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. :DataDiscovery/fix-it-week labels Jul 20, 2023
@jughosta jughosta mentioned this issue Jul 31, 2023
Merged
2 tasks
jughosta added a commit that referenced this issue Aug 2, 2023
@jughosta
[Discover] Replace deprecated page components (#162836)
148f9d7 
- Closes #161426

## Summary

This PR updates usage of Eui page components for the following plugins.
Also took this opportunity to make these pages a little nicer.

### src/plugins/data_view_management

Before:
<img width="600" alt="Screenshot 2023-07-31 at 20 09 28"
src="https://github.com/elastic/kibana/assets/1415710/5b52d31d-b759-40f9-8a8e-d428f6431f45">

After:
<img width="600" alt="Screenshot 2023-07-31 at 20 09 37"
src="https://github.com/elastic/kibana/assets/1415710/dfd738d9-fa19-41d2-a55e-6157d9f2310a">


### examples/search_examples

Before:
<img width="600" alt="Screenshot 2023-07-31 at 17 41 03"
src="https://github.com/elastic/kibana/assets/1415710/cc739f2d-bbaa-4cae-80d8-27599170a40a">

After:
<img width="600" alt="Screenshot 2023-07-31 at 18 01 47"
src="https://github.com/elastic/kibana/assets/1415710/ab596aae-f9b4-48f0-8401-a507f4814624">

Before:
<img width="600" alt="Screenshot 2023-07-31 at 20 30 19"
src="https://github.com/elastic/kibana/assets/1415710/40327fdd-7161-4d65-86ff-ff38455477fb">

After:
<img width="600" alt="Screenshot 2023-07-31 at 20 30 39"
src="https://github.com/elastic/kibana/assets/1415710/8455c09f-6d84-4ad1-9e25-f8555a4f40db">

Before:
<img width="600" alt="Screenshot 2023-07-31 at 18 20 47"
src="https://github.com/elastic/kibana/assets/1415710/68b05f4a-fcc0-4051-92b4-88a34bd22fb6">

After:
<img width="600" alt="Screenshot 2023-07-31 at 18 44 32"
src="https://github.com/elastic/kibana/assets/1415710/1fd00e7e-3663-470f-927a-b7d7a0fe6c20">

### examples/partial_results_example

Before:
<img width="600" alt="Screenshot 2023-07-31 at 17 29 32"
src="https://github.com/elastic/kibana/assets/1415710/589a2d93-c42a-4948-b805-0447e96f8ae4">

After:
<img width="600" alt="Screenshot 2023-07-31 at 17 31 52"
src="https://github.com/elastic/kibana/assets/1415710/22df2b40-a9ec-4e11-b4dc-19da86c73059">

### examples/field_formats_example

Before:
<img width="600" alt="Screenshot 2023-07-31 at 17 27 44"
src="https://github.com/elastic/kibana/assets/1415710/d3fa1fc3-e3e2-4f69-87e5-7187f8d3b000">

After:
<img width="600" alt="Screenshot 2023-07-31 at 17 27 56"
src="https://github.com/elastic/kibana/assets/1415710/5633dba4-85ed-4767-bc8c-dee0c4da8798">

### examples/data_view_field_editor_example

Before:
<img width="600" alt="Screenshot 2023-07-31 at 17 33 15"
src="https://github.com/elastic/kibana/assets/1415710/0be36a57-aef3-4679-ac77-9d5073b72fc2">

After:
<img width="600" alt="Screenshot 2023-07-31 at 17 37 34"
src="https://github.com/elastic/kibana/assets/1415710/e43b0a1d-12fe-4d06-90b0-63cbc36e5ac2">


### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@cee-chen
Copy link
Contributor Author

cee-chen commented Aug 2, 2023

Thanks for jumping on this - y'all rock! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
deprecation_warnings EUI Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Replace deprecated page components jughosta/kibana
5 participants
@kertal @cee-chen @jughosta @elasticmachine @davismcphee