Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps] Migrate all usages of EuiPage*_Deprecated #161421

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 3 comments · Fixed by #166188
Closed
Tracked by #161872

[ResponseOps] Migrate all usages of EuiPage*_Deprecated #161421

cee-chen opened this issue Jul 7, 2023 · 3 comments · Fixed by #166188
Assignees
@adcoelho
Labels
deprecation_warnings EUI Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Jul 7, 2023 •
edited
Loading

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have usages of EuiPage*_Deprecated components (per Kibana CODEOWNERS), which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added deprecation_warnings EUI Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen changed the title [Triggers Actions UI] Migrate all usages of EuiPage*_Deprecated [ResponseOps] Migrate all usages of EuiPage*_Deprecated Jul 7, 2023
@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@cnasikas cnasikas added the Feature:Cases Cases feature label Aug 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@adcoelho adcoelho mentioned this issue Sep 11, 2023
Merged
adcoelho added a commit that referenced this issue Sep 12, 2023
@adcoelho
[ResponseOps] Migrate all usages of EuiPage*_Deprecated (#166188)
6fc5c80 
Fixes #161421

## Summary

As mentioned in the linked issue, I migrated all usages of
`EuiPage*_Deprecated` components listed below:


[x-pack/triggers_actions_ui](https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fplugins%5C%2Ftriggers_actions_ui%2F&type=code)

[x-pack/examples/triggers_actions_ui_examples](https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fexamples%5C%2Ftriggers_actions_ui_example%2F&type=code)

[x-pack/examples/alerting_example](https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3Ax-pack%2Fexamples%2Falerting_example&type=code)

[x-pack/test/functional_with_es_ssl/plugins/cases](https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3Ax-pack%2Ftest%2Ffunctional_with_es_ssl%2Fplugins%2Fcases&type=code)

The majority of these were in test environments and examples.

The only one actually in `x-pack/triggers_actions_ui` had to do with the
rule detail page. It looked basically the same after the change but a
`Pager` that was there became unnecessary. I removed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
deprecation_warnings EUI Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps] Migrate all usages of EuiPage*_Deprecated adcoelho/kibana
4 participants
@cee-chen @adcoelho @cnasikas @elasticmachine