Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Migrate all usages of EuiPage*_Deprecated #161418

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 6 comments · Fixed by #162390
Closed
Tracked by #161872

[Fleet] Migrate all usages of EuiPage*_Deprecated #161418

cee-chen opened this issue Jul 7, 2023 · 6 comments · Fixed by #162390
Assignees
@criamico
Labels
deprecation_warnings EUI Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Jul 7, 2023

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have 2 usages of EuiPage*_Deprecated components, which you can find listed here:

https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fplugins%5C%2Ffleet%2F&type=code

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added deprecation_warnings EUI Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@jlind23
Copy link
Contributor

jlind23 commented Jul 17, 2023

@juliaElastic @criamico do we still rely on any deprecated Eui component?

@juliaElastic
Copy link
Contributor

Checked the usages, and found only 2 of them. Should be a small effort to fix.

EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
https://github.com/search?q=repo%3Aelastic%2Fkibana+EuiPageContent_Deprecated+path%3Ax-pack%2Fplugins%2Ffleet&type=code

@criamico
Copy link
Contributor

I'm looking into it, it should be a very quick PR

@criamico criamico self-assigned this Jul 18, 2023
@criamico criamico mentioned this issue Jul 24, 2023
Merged
criamico added a commit that referenced this issue Jul 24, 2023
@criamico @kibanamachine
[Fleet] Remove usage of deprecated component EuiPageContent_Deprecated (
cb54c98 
#162390)

Fixes #161418

## Summary
Removing usage of deprecated component `EuiPageContent_Deprecated` and
replacing with `EuiPageSection`.

Also removed two unused components.

The two components look like this:

<img width="1001" alt="Screenshot 2023-07-20 at 17 03 05"
src="https://github.com/elastic/kibana/assets/16084106/82798d53-30ae-455b-b0fc-216461f8d1b8">

<img width="1683" alt="Screenshot 2023-07-24 at 11 02 57"
src="https://github.com/elastic/kibana/assets/16084106/f6ca00a5-49b3-481e-9152-d1f2a77d4495">


To display them, I simply hardcoded `true`
[here](https://github.com/elastic/kibana/blob/59450f0a22bb8c34598d7156dcbf144d41752259/x-pack/plugins/fleet/public/applications/fleet/sections/agents/index.tsx#L60)
and
[here](https://github.com/elastic/kibana/blob/59450f0a22bb8c34598d7156dcbf144d41752259/x-pack/plugins/fleet/public/applications/fleet/sections/agents/index.tsx#L66)

---------

Co-authored-by: Kibana Machine <[email protected]>
@cee-chen
Copy link
Contributor Author

🎉 Huge thanks for jumping on this so quickly - y'all rock!

ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@criamico @kibanamachine
[Fleet] Remove usage of deprecated component EuiPageContent_Deprecated (
14f1d98 
elastic#162390)

Fixes elastic#161418

## Summary
Removing usage of deprecated component `EuiPageContent_Deprecated` and
replacing with `EuiPageSection`.

Also removed two unused components.

The two components look like this:

<img width="1001" alt="Screenshot 2023-07-20 at 17 03 05"
src="https://github.com/elastic/kibana/assets/16084106/82798d53-30ae-455b-b0fc-216461f8d1b8">

<img width="1683" alt="Screenshot 2023-07-24 at 11 02 57"
src="https://github.com/elastic/kibana/assets/16084106/f6ca00a5-49b3-481e-9152-d1f2a77d4495">


To display them, I simply hardcoded `true`
[here](https://github.com/elastic/kibana/blob/59450f0a22bb8c34598d7156dcbf144d41752259/x-pack/plugins/fleet/public/applications/fleet/sections/agents/index.tsx#L60)
and
[here](https://github.com/elastic/kibana/blob/59450f0a22bb8c34598d7156dcbf144d41752259/x-pack/plugins/fleet/public/applications/fleet/sections/agents/index.tsx#L66)

---------

Co-authored-by: Kibana Machine <[email protected]>
@Karql Karql mentioned this issue Feb 10, 2024
Closed
@peruukki peruukki mentioned this issue Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criamico criamico

Labels
deprecation_warnings EUI Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Remove usage of deprecated component EuiPageContent_Deprecated criamico/kibana
5 participants
@cee-chen @elasticmachine @criamico @jlind23 @juliaElastic