Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra][Monitoring] Migrate all usages of EuiPage*_Deprecated #161404

Closed
Tracked by #161872
cee-chen opened this issue Jul 6, 2023 · 4 comments · Fixed by #161870
Closed
Tracked by #161872

[Infra][Monitoring] Migrate all usages of EuiPage*_Deprecated #161404

cee-chen opened this issue Jul 6, 2023 · 4 comments · Fixed by #161870
Assignees
@crespocarlos
Labels
deprecation_warnings EUI Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture v8.9.0

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Jul 6, 2023 •
edited
Loading

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have usages of EuiPage*_Deprecated components, which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services deprecation_warnings EUI labels Jul 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen changed the title [Infra] Convert all usages of EuiPage*_Deprecated to their new non-deprecated equivalents [Infra] Migrate all usages of EuiPage*_Deprecated Jul 6, 2023
@cee-chen cee-chen changed the title [Infra] Migrate all usages of EuiPage*_Deprecated [Infra][Monitoring] Migrate all usages of EuiPage*_Deprecated Jul 7, 2023
@smith smith added technical debt Improvement of the software architecture and operational architecture Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Feature:Stack Monitoring v8.10.0 v8.9.0 and removed v8.10.0 labels Jul 7, 2023
@smith
Copy link
Contributor

smith commented Jul 7, 2023

Moved this to Ready so we'll pick it up shortly, hopefully before 8.9 release.

@crespocarlos crespocarlos self-assigned this Jul 13, 2023
@crespocarlos crespocarlos mentioned this issue Jul 13, 2023
Merged
@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
crespocarlos added a commit that referenced this issue Jul 20, 2023
@crespocarlos @kibanamachine
[Infra UI][Stack Monitoring] Migrate EuiPage*_Depracated usage (#161870)
b1a3bc5 
closes [#161404](#161404)

## Summary

This PR replaces the usage of `EuiPage*_Depracated` with their
equivalent components

Some usages of `EuiPageContent_Deprecated` have been replaced with
`EuiPanel` because they were displayed as panels, and the recommended
`EuiPageSection` component did not render in the same manner. e.g:

<img width="1690" alt="image"
src="https://github.com/elastic/kibana/assets/2767137/b86db831-e79e-4be0-918f-f3b25803e990">

code:
https://github.com/elastic/kibana/pull/161870/files#diff-72520cac696197524aff32e2b92a0acabe1898067c6985786fa5ac250a40ac1cR122


### How to test

- Start a local Kibana with metricbeat monitoring Beats, Kibana,
Elasticsearch and Logstash
- Navigate to Stack Monitoring and click through the links 
- Compare the UI (loading and error states included) with what's
currently in https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/
- Navigate to Infra UI and go to node details
- Compare the UI (loading and error states included) with what's
currently in https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/

---------

Co-authored-by: Kibana Machine <[email protected]>
@cee-chen
Copy link
Contributor Author

❤️ Thanks to you awesome folks for picking this up so quickly!

ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@crespocarlos @kibanamachine
[Infra UI][Stack Monitoring] Migrate EuiPage*_Depracated usage (elast…
71fae6e 
…ic#161870)

closes [elastic#161404](elastic#161404)

## Summary

This PR replaces the usage of `EuiPage*_Depracated` with their
equivalent components

Some usages of `EuiPageContent_Deprecated` have been replaced with
`EuiPanel` because they were displayed as panels, and the recommended
`EuiPageSection` component did not render in the same manner. e.g:

<img width="1690" alt="image"
src="https://github.com/elastic/kibana/assets/2767137/b86db831-e79e-4be0-918f-f3b25803e990">

code:
https://github.com/elastic/kibana/pull/161870/files#diff-72520cac696197524aff32e2b92a0acabe1898067c6985786fa5ac250a40ac1cR122


### How to test

- Start a local Kibana with metricbeat monitoring Beats, Kibana,
Elasticsearch and Logstash
- Navigate to Stack Monitoring and click through the links 
- Compare the UI (loading and error states included) with what's
currently in https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/
- Navigate to Infra UI and go to node details
- Compare the UI (loading and error states included) with what's
currently in https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crespocarlos crespocarlos

Labels
deprecation_warnings EUI Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra UI][Stack Monitoring] Migrate EuiPage*_Depracated usage crespocarlos/kibana
4 participants
@smith @cee-chen @crespocarlos @elasticmachine