Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack API Integration Tests - ml.x-pack/test/api_integration/apis/ml/jobs/update_groups·ts - Machine Learning jobs update groups "before all" hook for "returns expected list of groups after update" #161324

Closed
kibanamachine opened this issue Jul 6, 2023 · 9 comments
Closed

Failing test: X-Pack API Integration Tests - ml.x-pack/test/api_integration/apis/ml/jobs/update_groups·ts - Machine Learning jobs update groups "before all" hook for "returns expected list of groups after update" #161324

kibanamachine opened this issue Jul 6, 2023 · 9 comments
Assignees
@jgowdyelastic
Labels
failed-test A test failure on a tracked branch, potentially flaky-test :ml

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 6, 2023 •
edited
Loading

A test failed on a tracked branch

Error: Expected status code 200, got 409 with body '{"statusCode":409,"error":"Conflict","message":"Saved object [ml-job/anomaly-detector-jobs_summary_fq_single_1688631729573] conflict"}'
    at Assertion.assert (expect.js:100:11)
    at Assertion.eql (expect.js:244:8)
    at Object.assertResponseStatusCode (api.ts:87:31)
    at Object.createAnomalyDetectionJob (api.ts:688:12)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Context.<anonymous> (update_groups.ts:66:9)
    at Object.apply (wrap_function.js:73:16) {
  actual: '409',
  expected: '200',
  showDiff: true
}

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jul 6, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 6, 2023
@jgowdyelastic jgowdyelastic mentioned this issue Jul 6, 2023
Merged
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@dmlemeshko
Copy link
Member

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 3495720

kibanamachine added a commit that referenced this issue Jul 7, 2023
@kibanamachine
skip failing test suite (#161324)
3495720
@peteharverson
Copy link
Contributor

Removing the blocker label as the job reset functionality is working fine in manual testing. A fix is in progress for 8.10 - #161326.

jgowdyelastic added a commit that referenced this issue Jul 18, 2023
@jgowdyelastic
[ML] Fix flaky update_groups api test (#161326)
5548e12 
Related to #161324 and
#160370
Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2649

I believe the problem lies with the function `cleanMLSavedObjects` only
cleaning up saved objects in the default space and not in any other of
the spaces which jobs or trained models may have been added to.
This causes an intermittent clash where a job's saved object already
exists, but is in a different space. I don't know why this doesn't fail
on every run.
The fix is to update `cleanMLSavedObjects` so it can take a list of
additional space IDs to also clean. Any test which adds jobs or trained
models to spaces other than `default` need to call this function and
supply the list of space IDs it is using.
I've updated every test I could find in this PR.
@jgowdyelastic
Copy link
Member

Fixed by #161326

ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@jgowdyelastic
[ML] Fix flaky update_groups api test (elastic#161326)
2e3adf4 
Related to elastic#161324 and
elastic#160370
Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2649

I believe the problem lies with the function `cleanMLSavedObjects` only
cleaning up saved objects in the default space and not in any other of
the spaces which jobs or trained models may have been added to.
This causes an intermittent clash where a job's saved object already
exists, but is in a different space. I don't know why this doesn't fail
on every run.
The fix is to update `cleanMLSavedObjects` so it can take a list of
additional space IDs to also clean. Any test which adds jobs or trained
models to spaces other than `default` need to call this function and
supply the list of space IDs it is using.
I've updated every test I could find in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgowdyelastic jgowdyelastic

Labels
failed-test A test failure on a tracked branch, potentially flaky-test :ml
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@peteharverson @dmlemeshko @elasticmachine @jgowdyelastic @kibanamachine