Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard][Event annotations][Lens] append postfix when duplicate title instead of interrupting save flow #161119

Closed
drewdaemon opened this issue Jul 3, 2023 · 10 comments
Closed

[Dashboard][Event annotations][Lens] append postfix when duplicate title instead of interrupting save flow #161119

drewdaemon opened this issue Jul 3, 2023 · 10 comments
Assignees
@paulinashakirova
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) usability

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Jul 3, 2023 •
edited
Loading

Describe the feature:
Today, when a user is about to save a piece of content with a duplicate title, they are interrupted by a warning. If they click "save" again after the warning is shown, they are allowed to save with a duplicate title.

In #152623 (comment), @MichaelMarcialis suggested a new pattern in which no warning is shown and the save is allowed to occur with a postfix attached to the duplicate title Edit: that we populate the title field with the existing title + postfix (e.g. my duplicate title [1]) when the user selects "save as new."

Today:
Screenshot 2023-06-30 at 2 46 23 PM

Not sure which team would take this (maybe SharedUX eventually)?
@drewdaemon drewdaemon added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@drewdaemon drewdaemon added the papercut Small "burr" in the product that we should fix. label Jul 3, 2023
@MichaelMarcialis
Copy link
Contributor

@drewdaemon: Just to clarify, I'm not proposing that the duplicate name warning callout and the numeral suffix would be mutually exclusive; I'm just proposing that the populating of a name that is already in use not be the default experience (and the warning callout that comes with it).

For example, based on your screenshot above, the numeral suffix would only be auto-populated if 1) the user hasn't altered the title to something unused and 2) the user turns on the switch to save as a new saved object. At the same time, if the user were to manually remove that numeral suffix or use some other existing saved object name, the warning callout should still indicate that fact to the user.

@drewdaemon drewdaemon added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jul 12, 2023
@gitstart gitstart mentioned this issue Jul 19, 2023
Open
@timductive timductive added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jul 26, 2023
@drewdaemon drewdaemon added usability and removed papercut Small "burr" in the product that we should fix. labels Aug 4, 2023
@ThomThomson
Copy link
Contributor

@drewdaemon has there been any movement on this? Is it something that we should keep open do you think?

@drewdaemon
Copy link
Contributor Author

@ThomThomson no movement, but still an actionable usability enhancement to consider.

The ownership of that saved object modal is a little unclear. Technically Core for now, but they don't believe they should own it and won't make any changes there. So, it seems like it will probably be an analyst XP team or maybe shared UX.

@ThomThomson
Copy link
Contributor

IMO this should be part of the UI phase of the Content Management project. These SO modals are very disjointed at the moment / spread out around many different plugins.

@drewdaemon
Copy link
Contributor Author

Yeah, feels right to me. WDYT @vadimkibana ? Can we send this to SharedUX?

@stratoula stratoula added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@stratoula
Copy link
Contributor

Sending this to the shared ux team to decide if they want to keep it open or close it

@petrklapka
Copy link
Member

Triage on Feb 5th 2024 - Decided to keep it open but agree with Thom's CM comment. It will go into the icebox until CM gets more traction.

@paulinashakirova paulinashakirova self-assigned this Oct 29, 2024
@paulinashakirova paulinashakirova mentioned this issue Nov 4, 2024
Merged
paulinashakirova added a commit that referenced this issue Nov 6, 2024
@paulinashakirova
feat: SavedObjectSaveModal - add postfix if the title is duplicated (#…
b8dbf83 
…198777)

## Summary

This PR fixes the issue with the [[Dashboard][Event annotations][Lens]
appending a postfix when there is a duplicate title instead of
interrupting the save
flow](#161119).

Currently, if a user wants to save an object as a new group without
modifying the title, they will see a warning about it.

This PR introduces an additional step. If the user attempts to save an
object as a new group, we automatically append a postfix to the title.
If the user manually changes the title back to the original and tries to
save it, they will see the currently configured warning.


https://github.com/user-attachments/assets/4f764b75-5b83-4277-8e5e-42fe1174fae7
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 6, 2024
@paulinashakirova
feat: SavedObjectSaveModal - add postfix if the title is duplicated (e…
dbad3a5 
…lastic#198777)

## Summary

This PR fixes the issue with the [[Dashboard][Event annotations][Lens]
appending a postfix when there is a duplicate title instead of
interrupting the save
flow](elastic#161119).

Currently, if a user wants to save an object as a new group without
modifying the title, they will see a warning about it.

This PR introduces an additional step. If the user attempts to save an
object as a new group, we automatically append a postfix to the title.
If the user manually changes the title back to the original and tries to
save it, they will see the currently configured warning.

https://github.com/user-attachments/assets/4f764b75-5b83-4277-8e5e-42fe1174fae7
(cherry picked from commit b8dbf83)
mgadewoll pushed a commit to mgadewoll/kibana that referenced this issue Nov 7, 2024
@paulinashakirova @mgadewoll
feat: SavedObjectSaveModal - add postfix if the title is duplicated (e…
925f9d0 
…lastic#198777)

## Summary

This PR fixes the issue with the [[Dashboard][Event annotations][Lens]
appending a postfix when there is a duplicate title instead of
interrupting the save
flow](elastic#161119).

Currently, if a user wants to save an object as a new group without
modifying the title, they will see a warning about it.

This PR introduces an additional step. If the user attempts to save an
object as a new group, we automatically append a postfix to the title.
If the user manually changes the title back to the original and tries to
save it, they will see the currently configured warning.


https://github.com/user-attachments/assets/4f764b75-5b83-4277-8e5e-42fe1174fae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulinashakirova paulinashakirova

Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@drewdaemon @timductive @MichaelMarcialis @ThomThomson @elasticmachine @stratoula @paulinashakirova @petrklapka