Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Skipped Test] Saved query validation error test #159060

Closed
Tracked by #161506
marshallmain opened this issue Jun 5, 2023 · 3 comments
Closed
Tracked by #161506

[Security Solution][Skipped Test] Saved query validation error test #159060

marshallmain opened this issue Jun 5, 2023 · 3 comments
Assignees
@e40pud
Labels
skipped-test Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@marshallmain
Copy link
Contributor

As a result of #157749, this test was skipped. After refactoring, we no longer run the form validation on loading the Edit Rule form so the error does not appear like the test asserts.

We should either fix or remove the skipped test. While evaluating what to do, we should consider whether a saved query failing to load still makes sense as a validation error, or if it could be represented in another way such as a toast similar to the rule details page.
@marshallmain marshallmain added skipped-test Team:Detections and Resp Security Detection Response Team Team:Detection Engine Security Solution Detection Engine Area labels Jun 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@marshallmain marshallmain mentioned this issue Jun 5, 2023
Merged
@e40pud e40pud self-assigned this Jul 24, 2023
@WafaaNasr WafaaNasr mentioned this issue Jul 26, 2023
Closed
@banderror banderror added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Jul 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

e40pud added a commit to e40pud/kibana that referenced this issue Aug 3, 2023
@e40pud
[Security Solution][Skipped Test] Saved query validation error test e…
ab4ff17 
…lastic#159060
@e40pud e40pud mentioned this issue Aug 3, 2023
Merged
e40pud added a commit that referenced this issue Aug 14, 2023
@e40pud
[Security Solution][Skipped Test] Saved query validation error test (#…
3d8e425 
…163050)

## Summary

Original ticket: #159060 

This PR un-skips test which was disabled after the Rule Editing page
[refactoring](#157749). There we
stopped fields validation on page loading. To be able to show the
"failed to load saved query" error on page loading we force the field
validation when we failed to load a saved query.
@e40pud
Copy link
Contributor

e40pud commented Aug 14, 2023

Fixed by #163050

@e40pud e40pud closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e40pud e40pud

Labels
skipped-test Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@e40pud @banderror @elasticmachine @marshallmain