-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detach spy panel from visualization #15901
Comments
Great idea. I've always thought of the spy panel as being a debug tool for a visualization anyways so having it detached makes perfect sense to me. Also, I never have opened more than one spy panel open at a time and my users use searches or data tables when wanting to view the data in a non-graphical way which I think makes more sense then the spy panel approach. |
There's a small issue you might fix along with this change. On Discover, you can only get to the spy panel for time-based indices. I think it's because the button to get to it is on the bottom of the histogram which you only get on time-based indices. But there's plenty of reasons you might want to see the request, response, statistics, for non-time-based indices. |
Good idea to extract the spy out of the visualization panel! How about we use the |
Whoa, haven't checked in the new UI framework in awhile. You all have been busy. I'm really liking the fact that the 50 shades of green are going to be a thing of the past with the much more manageable color palette. |
@cjcenizal of course that makes more sense. I missed that one. In the long run we would like to make it positionable on the screen and resizeable (pretty much like dev tools are). Do you think you could add a |
@timroes These are great ideas about specifying position and supporting resizability. Would you mind opening an issue on the EUI repo? If you have time + inclination, you are also welcome to open a PR. |
Currently the spy panel is rendered by the
<visualization>
directive into its parent container. This has several drawback:<visualization>
directive, but it doesn't work if the visualization is rendered without using the directive. This e.g. means, that TSVB could have a spy panel when placed on dashboard, but not while opened in editor mode. Same for everything else, that using the default editor, unless they implement spy panels by themself.This issue tracks the progress of making the spy panel for a visualization a more detached solution. This solution should be usable no matter what size the visualization have. It should also be able to trigger it by any button, so we can place the trigger for different visualizations in different places (e.g. it could be in the panel header when placed on a dashboard).
After some discussions with @alexfrancoeur we think, that a "dev tools like experience" could be a good solution. We could use something similar to the
BottomBar
layout from the UI framework:Ideally this panel could be rearranged on the screen and maybe even resized. The huge disadvantage of this solution would be, that we lose the possibility for multiple visualizations having their spy panel opened and create a user experience that is more focused on temporarily debug a specific visualization.
The text was updated successfully, but these errors were encountered: