Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach spy panel from visualization #15901

Closed
timroes opened this issue Jan 8, 2018 · 6 comments · Fixed by #16387
Closed

Detach spy panel from visualization #15901

timroes opened this issue Jan 8, 2018 · 6 comments · Fixed by #16387
Assignees
Labels
Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement

Comments

@timroes
Copy link
Contributor

timroes commented Jan 8, 2018

Currently the spy panel is rendered by the <visualization> directive into its parent container. This has several drawback:

This issue tracks the progress of making the spy panel for a visualization a more detached solution. This solution should be usable no matter what size the visualization have. It should also be able to trigger it by any button, so we can place the trigger for different visualizations in different places (e.g. it could be in the panel header when placed on a dashboard).

After some discussions with @alexfrancoeur we think, that a "dev tools like experience" could be a good solution. We could use something similar to the BottomBar layout from the UI framework:

elastic github io_eui_

Ideally this panel could be rearranged on the screen and maybe even resized. The huge disadvantage of this solution would be, that we lose the possibility for multiple visualizations having their spy panel opened and create a user experience that is more focused on temporarily debug a specific visualization.

@timroes timroes added Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement labels Jan 8, 2018
@JacobBrandt
Copy link
Contributor

Great idea. I've always thought of the spy panel as being a debug tool for a visualization anyways so having it detached makes perfect sense to me. Also, I never have opened more than one spy panel open at a time and my users use searches or data tables when wanting to view the data in a non-graphical way which I think makes more sense then the spy panel approach.

@LeeDr
Copy link

LeeDr commented Jan 9, 2018

There's a small issue you might fix along with this change. On Discover, you can only get to the spy panel for time-based indices. I think it's because the button to get to it is on the bottom of the histogram which you only get on time-based indices. But there's plenty of reasons you might want to see the request, response, statistics, for non-time-based indices.

@cjcenizal
Copy link
Contributor

cjcenizal commented Jan 9, 2018

Good idea to extract the spy out of the visualization panel! How about we use the EuiFlyout component instead? I think this is the component we'll typically use for "drilling down" into an object's details. The bottom bar is mostly for actions tied to a multi-step and/or full-page form, wizard, or document.

image

@JacobBrandt
Copy link
Contributor

Whoa, haven't checked in the new UI framework in awhile. You all have been busy. I'm really liking the fact that the 50 shades of green are going to be a thing of the past with the much more manageable color palette.

@timroes
Copy link
Contributor Author

timroes commented Jan 10, 2018

@cjcenizal of course that makes more sense. I missed that one. In the long run we would like to make it positionable on the screen and resizeable (pretty much like dev tools are). Do you think you could add a position="top|left|right|bottom" attribute to position it? Also do you think something like a manual resizing should rather be build into the component (resizeable={true}) or should be implemented when the component is used and overwrite the size of it?

@cjcenizal
Copy link
Contributor

@timroes These are great ideas about specifying position and supporting resizability. Would you mind opening an issue on the EUI repo? If you have time + inclination, you are also welcome to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants