Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Negative time offsets aren't consistent with positive offsets #15553

Closed
LeeDr opened this issue Dec 12, 2017 · 0 comments · Fixed by #15554
Closed

[TSVB] Negative time offsets aren't consistent with positive offsets #15553

LeeDr opened this issue Dec 12, 2017 · 0 comments · Fixed by #15554
Assignees
@timroes
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@LeeDr
Copy link

LeeDr commented Dec 12, 2017

Kibana version: 6.1.0

Elasticsearch version: 6.1.0

Server OS version: Ubuntu 14.04

Browser version: Chrome

Browser OS version: Windows 10

Original install method (e.g. download page, yum, from source, etc.): .deb packages

Description of the problem including expected versus actual behavior:
Re: #14494

This doesn't seem to work right. Positive offsets shift the data in time, but negative offsets shift the chart timespan.

image

image

image

Steps to reproduce:

  1. Create a new Time Series visualization
  2. Select your timespan where you see some distinctive data pattern
  3. In the Data > Options panel, set the Offset series time to positive 1h and negative -1h and watch the shifting of data
    image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):
@LeeDr LeeDr added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Dec 12, 2017
@timroes timroes self-assigned this Dec 12, 2017
timroes pushed a commit to timroes/kibana that referenced this issue Dec 12, 2017
Shift negative series before drawing, fix elastic#15553
f45770c
@timroes timroes mentioned this issue Dec 12, 2017
Merged
timroes added a commit that referenced this issue Dec 16, 2017
@timroes
Fix bug where negative time offsets in visual builder will shift x-ax…
4671aa5 
…is range (#15554)

* Shift negative series before drawing, fix #15553

* Add tests fot TSVB markdown

* Use waitUntilLoadingHasFinished

* Remove forgotten skip

* Switch test order

* Use generic seriesOption

* Rename test from chart to metric

* Use test subj to find metric tabs

* Improve TSVB tests
timroes added a commit to timroes/kibana that referenced this issue Dec 16, 2017
@timroes
Fix bug where negative time offsets in visual builder will shift x-ax…
7215b46 
…is range (elastic#15554)

* Shift negative series before drawing, fix elastic#15553

* Add tests fot TSVB markdown

* Use waitUntilLoadingHasFinished

* Remove forgotten skip

* Switch test order

* Use generic seriesOption

* Rename test from chart to metric

* Use test subj to find metric tabs

* Improve TSVB tests
timroes added a commit to timroes/kibana that referenced this issue Dec 16, 2017
@timroes
Fix bug where negative time offsets in visual builder will shift x-ax…
cc4c497 
…is range (elastic#15554)

* Shift negative series before drawing, fix elastic#15553

* Add tests fot TSVB markdown

* Use waitUntilLoadingHasFinished

* Remove forgotten skip

* Switch test order

* Use generic seriesOption

* Rename test from chart to metric

* Use test subj to find metric tabs

* Improve TSVB tests
timroes added a commit that referenced this issue Dec 16, 2017
@timroes
Fix bug where negative time offsets in visual builder will shift x-ax…
e5eb9d0 
…is range (#15554) (#15650)

* Shift negative series before drawing, fix #15553

* Add tests fot TSVB markdown

* Use waitUntilLoadingHasFinished

* Remove forgotten skip

* Switch test order

* Use generic seriesOption

* Rename test from chart to metric

* Use test subj to find metric tabs

* Improve TSVB tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug where negative time offsets in visual builder will shift x-axis range timroes/kibana
2 participants
@timroes @LeeDr