-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure UI] Asset Details: Add pins to the metadata table #155190
Comments
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Regarding the pins I will add a separate issue for it, just have a couple of questions there: Answering your questions @jennypavlova here :) - As for the component and if it's the first time using it - So it is present on 'Analytics' - Discover. I think the closest thing in the EUI to this is the 'adding actions' to the table' section (where btw is the "Actions" column from the other designs :) About Do we want to persist the order of the pins (in case they change the table order) in the url and make it sharable? |
Hey @kkurstak / @jennypavlova - I think we share the filters in the table, just not the pinning (pinning would be great but, assuming that the pins are stored in local storage, we don't want to override another user's saved pins by opening a URL). Make sense? Food for thought... BTW we should start thinking ahead (not in this issue - just in general) about what fly-outs would look like if they were the same everywhere in the UI (i.e. have one consistent fly-out for a host no matter where it is opened from). Note : We may decide this fly-out should change depending on the context (or give the Elastic engineer, who wants to add a fly-out, a choice over what should render) |
@kkurstak @roshan-elastic Thanks for the comments!
I am wondering if we want to have the alphabetical order like in Discover or if we want to persist in the current order (host -> cloud -> agent). I experimented a bit and I think the current order looks good but want to hear your opinion. The background around is that we already have the metadata sorted in a certain way and if we introduce different sorting can be confusing (the lack of sorting and just moving the pins can look also messy) so I did something like: Screen.Recording.2023-04-26.at.13.59.50.movThat way the Screen.Recording.2023-04-26.at.14.23.25.movEdit: Example with cloud metadata: PS: Ignore the Add/Remove pin tooltips in the videos - the tooltips are Pin Field/Unpin field like in Discover it was the WIP state What do you think about this order, does it make sense? |
As discussed with @roshan-elastic we are closing this for now as we will probably replace the flyout with an embeddable in 8.9. I will keep the branch and close the issue and the PR for now. |
Reopening this to be re-included in some host flyout updates. |
I will adapt the solution there to the new asset details embeddable ( using the closed PR and opening a new one once it's done). |
β¦61074) Closes #155190 ## Summary This PR adds the possibility to pin different rows inside the metadata table in asset details embeddable. The pins are persisted in the local storage and should be available after refreshing/reopening the host flyout. The order and sorting are explained in [this comment](#155190 (comment)), so basically we keep the original sorting order of the table (`host`, `cloud`, `agent`) also for the pins. ## Testing - Go to hosts view and open a single host flyout (metadata tab) - Try to add / remove pins - Check if the pins are persisted after a page refresh https://github.com/elastic/kibana/assets/14139027/62873e7e-b5f0-444c-94ff-5e19f2f46f58
π Summary
Inside the single hosts flyout metadata table add an option for the user to pin a table row.
π¨ Design
Figma
π¨βπ» Implementation hints
We can check a Pinnable list group or search for an eui table with pins support. The pinned items should be persisted for the current user (locale storage)
βοΈ Acceptance criteria
The text was updated successfully, but these errors were encountered: