Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Trace waterfall is not cleared when there are no results #154705

Closed
dgieselaar opened this issue Apr 11, 2023 · 5 comments · Fixed by #163397
Closed

[APM] Trace waterfall is not cleared when there are no results #154705

dgieselaar opened this issue Apr 11, 2023 · 5 comments · Fixed by #163397
Assignees
Labels
8.10 candidate apm:test-plan-done Pull request that was successfully tested during the test plan apm:waterfall bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@dgieselaar
Copy link
Member

dgieselaar commented Apr 11, 2023

When navigating to the transaction detail view, and there is at least one sampled transaction, the trace waterfall will show a trace. However, when navigating to a state that yields no sampled transactions, e.g. when selecting a different transaction type or a kuery, the waterfall is not cleared. The following shows the initial state with sampled transactions:

CleanShot 2023-04-11 at 10 06 13@2x

This is what it looks like when there are no sampled transactions. The waterfall is still visible but the sample selection is gone.

CleanShot 2023-04-11 at 10 07 02@2x

When the user navigates to a transaction group without any samples from a different page, the loading state displays indefinitely. We should also try to address that.

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Apr 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@akhileshpok
Copy link

@gbamparop - I would suggest that we raise the priority of this issue, due to user impact.

@dgieselaar
Copy link
Member Author

You can reproduce the infinite loading state by going to a frontend service and adding NOT (transaction.sampled:true) to the search bar. This causes no samples to be returned, even though there are transactions available. It only happens for RUM services, because we keep unsampled transactions. In all other cases, samples are pretty much guaranteed to be available if there are transaction metrics for that transaction group.

@achyutjhunjhunwala
Copy link
Contributor

Issue can be easily reproduced here

  1. Issue 1 - Where Latency Distribution is empty but Trace Sample is present -
    Navigate to a RUM Agent supported Service - here
    Change request type to route-change

  2. Issue 2 - Infinite Loading - here

@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Aug 3, 2023
achyutjhunjhunwala added a commit that referenced this issue Aug 9, 2023
…63397)

## Summary

Closes #154705

## List of Issues

- Trace Waterfall not clearing and persisting old data

![Trace Explorer Not
clearing](https://github.com/elastic/kibana/assets/7416358/5302c5ed-0c92-44ab-81a5-115e32dc8ace)

- Infinite Loading of Trace Waterfall where no traces are present and
page is reloaded

![Infinite
Loading](https://github.com/elastic/kibana/assets/7416358/c5ae1cda-099e-4968-96e5-ad85db38d83a)

- After Fixing these 2 issues, found issue with Container Height

![Container Height
Issue](https://github.com/elastic/kibana/assets/7416358/7fc7ef1b-68dc-4f52-bc2f-c346cfd5f67e)

## All issues fixed

![All issues
resolved](https://github.com/elastic/kibana/assets/7416358/227fe648-d6b9-4788-8961-7369f6ed621a)
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
…astic#163397)

## Summary

Closes elastic#154705

## List of Issues

- Trace Waterfall not clearing and persisting old data

![Trace Explorer Not
clearing](https://github.com/elastic/kibana/assets/7416358/5302c5ed-0c92-44ab-81a5-115e32dc8ace)

- Infinite Loading of Trace Waterfall where no traces are present and
page is reloaded

![Infinite
Loading](https://github.com/elastic/kibana/assets/7416358/c5ae1cda-099e-4968-96e5-ad85db38d83a)

- After Fixing these 2 issues, found issue with Container Height

![Container Height
Issue](https://github.com/elastic/kibana/assets/7416358/7fc7ef1b-68dc-4f52-bc2f-c346cfd5f67e)

## All issues fixed

![All issues
resolved](https://github.com/elastic/kibana/assets/7416358/227fe648-d6b9-4788-8961-7369f6ed621a)
@achyutjhunjhunwala
Copy link
Contributor

achyutjhunjhunwala commented Aug 16, 2023

Tested on edge-lite and looks good

Trace Waterfall Test Plan

Awaiting for Overview cluster to upgrade to 8.10
We cannot use Overview clusters for Test plan due to the dependency on Release cycle which causes it to update quite late to the latest snapshot

@achyutjhunjhunwala achyutjhunjhunwala added the apm:test-plan-done Pull request that was successfully tested during the test plan label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.10 candidate apm:test-plan-done Pull request that was successfully tested during the test plan apm:waterfall bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants