Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] - Share the hook that fetches the alert annotations in the Alert Details page #154170

Closed
Tracked by #150854
fkanout opened this issue Mar 31, 2023 · 1 comment · Fixed by #157178
Closed
Tracked by #150854

[AO] - Share the hook that fetches the alert annotations in the Alert Details page #154170

fkanout opened this issue Mar 31, 2023 · 1 comment · Fixed by #157178
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Mar 31, 2023 •
edited
Loading

🗒️ Summary

Part of #150854

Need to move the hook use_alerts_history under Infra and use_fetch_triggered_alert_history under APM to Observability to be shared across the plugins for all Alert Details pages (They share the same code)

✅ AC

  • Move and export the hook from Observability
  • Update Infra (Metrics, Logs) and APM code
  • Provide related test
@fkanout fkanout added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Mar 31, 2023
@fkanout fkanout self-assigned this Mar 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

This was referenced Mar 31, 2023
Merged
Closed
@fkanout fkanout added v8.9.0 and removed v8.8.0 labels May 9, 2023
@fkanout fkanout mentioned this issue May 9, 2023
Merged
fkanout added a commit that referenced this issue May 16, 2023
@fkanout
[AO] - Move the hook that fetches the alert annotations in the Alert …
24260d7 
…Details page to Observability (#157178)

## Summary
Fixes #154170 by:
- Make the `use_alerts_history`
[hook](https://github.com/elastic/kibana/blob/main/x-pack/plugins/infra/public/hooks/use_alerts_history.ts)
sharable: move it to the Observability package and updates the imports in
`APM` and `Infra` to use it
- Provided tests
jasonrhodes pushed a commit that referenced this issue May 17, 2023
@fkanout @jasonrhodes
[AO] - Move the hook that fetches the alert annotations in the Alert …
43d5501 
…Details page to Observability (#157178)

## Summary
Fixes #154170 by:
- Make the `use_alerts_history`
[hook](https://github.com/elastic/kibana/blob/main/x-pack/plugins/infra/public/hooks/use_alerts_history.ts)
sharable: move it to the Observability package and updates the imports in
`APM` and `Infra` to use it
- Provided tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Milestone
No milestone
2 participants
@fkanout @elasticmachine