Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs Alerting] Fix null value warning for metric threshold preview chart #154025

Closed
Tracked by #145117
maryam-saeidi opened this issue Mar 30, 2023 · 7 comments
Closed
Tracked by #145117
Labels
chore Team:obs-ux-management Observability Management User Experience Team v8.8.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Mar 30, 2023

UPDATE: We won't fix this in particular bug in the metric threshold rule, but we want to check other rules to see if a similar error is occurring and whether using NaN instead of null might solve the problem. More in this comment below.

📝 Summary

When in the chart data there are null values, a warning is shown in the console.

image

✅ Acceptance Criteria

  • Fix the above-mentioned warning
@maryam-saeidi maryam-saeidi added chore Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Mar 30, 2023
@maryam-saeidi maryam-saeidi self-assigned this Mar 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@emma-raffenne emma-raffenne added this to the 8.10 milestone Aug 7, 2023
@emma-raffenne emma-raffenne removed this from the 8.10 milestone Aug 17, 2023
@maryam-saeidi maryam-saeidi removed their assignment Nov 21, 2023
@paulb-elastic paulb-elastic added Team:obs-ux-management Observability Management User Experience Team and removed Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Feb 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@jasonrhodes jasonrhodes changed the title [AO] Fix null value warning for metric threshold preview chart [Obs Alerting] Fix null value warning for metric threshold preview chart Mar 27, 2024
@jasonrhodes
Copy link
Member

@maryam-saeidi do we know if this is still an issue?

@maryam-saeidi
Copy link
Member Author

@jasonrhodes Yes, it is still the case when I stop generating data, I will see this warning in the developer console but I don't know if we really want to invest time in the metric threshold preview chart, I would vote for closing this ticket.

image

@maryam-saeidi
Copy link
Member Author

maryam-saeidi commented Mar 28, 2024

@jasonrhodes To give you a bit more context, I saw this ticket that was similar to our case and I asked about it in Slack from charts team and the suggestion was to use NaN instead of null and it might help with this issue (comment)

Now, we are using a lens embeddable in the custom threshold rule's preview, so I suspect this issue is more relevant to the other rules that use the charts package directly. Maybe we should check other charts as well and if we have this issue in other places, we can come up with a generic approach to fix it everywhere.

@jasonrhodes
Copy link
Member

@maryam-saeidi sounds good, I added an update to the top of this issue description and then moved it to "Refining" status. If we discover there are other rules that need a fix and that NaN fixes it, let's create a new issue for that. Either way, once we've checked the other rules, we should close this issue.

@jasonrhodes
Copy link
Member

Closing this as it's been sitting for a while.

@jasonrhodes jasonrhodes reopened this Aug 14, 2024
@jasonrhodes jasonrhodes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:obs-ux-management Observability Management User Experience Team v8.8.0
Projects
None yet
Development

No branches or pull requests

5 participants