Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] Fix recovered badge color on the alert details page #153757

Closed
Tracked by #145117
maryam-saeidi opened this issue Mar 27, 2023 · 1 comment · Fixed by #154136
Closed
Tracked by #145117

[AO] Fix recovered badge color on the alert details page #153757

maryam-saeidi opened this issue Mar 27, 2023 · 1 comment · Fixed by #154136
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alert Details Page Observability ux management team Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Mar 27, 2023

📝 Summary

Currently, the color of Recovered badge` on the alert details page is red, and we need to change it to the correct color.

image

@maciejforcone Shall we use the same badge as the alert table?
image
Answer from @maciejforcone:
After a discussion with @mdefazio, for now, we should use EUI default badges.
https://elastic.github.io/eui/#/display/badge
image
recovered badge is "Healthy" from EUI, and "Active" is "Critical", so the same that exist in Alerts table already, to make it look consistent, and later we can update all to new ones, once they are available in EUI

Implementation hint

We can re-use the existing badge color that was created by trigger actions UI:
packages/kbn-alerts-ui-shared/src/alert_lifecycle_status_badge/index.tsx

✅ Acceptance Criteria

@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 Feature:Alert Details Page Observability ux management team labels Mar 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alert Details Page Observability ux management team Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants