Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Stabilize Cypress #153664

Closed
9 of 12 tasks
Tracked by #153633
MadameSheema opened this issue Mar 24, 2023 · 10 comments
Closed
9 of 12 tasks
Tracked by #153633

[Security Solution] Stabilize Cypress #153664

MadameSheema opened this issue Mar 24, 2023 · 10 comments
Assignees
Labels
8.11 candidate performance Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture test_ui_functional test

Comments

@MadameSheema
Copy link
Member

MadameSheema commented Mar 24, 2023

Kibana Operations team is open to have our tests executed on every PR, before arriving to that point there are a set of criteria our tests needs to meet first.

The aim of this ticket is to centralize all the work we have to do first before enabling our tests:

@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Mar 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@spong
Copy link
Member

spong commented Mar 24, 2023

Thanks for coordinating this effort and pushing it forward @MadameSheema! Really excited this is so close happening finally! 🙂

Two questions with regards to the acceptance criteria from the ops side:

  1. In the event of flake, what automation exists for auto-skipping and follow-up issue creation/assignment? Can we get the @kibanamachine automation (sample jest issue) working with the cypress tests too? Is there a buildkite dashboard tracking failures across all builds we can reference?
  2. Even with documenting best practices for test development and to reduce flake (#153662 #153655), flake will find a way 🦖 🦕. Would it be possible to get cypress support in the flakey test runner? Then we can at least stress test new suites before hitting main.

edit: Looks like the flakey test runner supports the cypress CI jobs now! I hadn't realized, so we should be good here now 🙂

@MadameSheema
Copy link
Member Author

Hey @spong!! Yes! We should work on the first point as well, there are even more tasks we will need to implement, like automate the number of parallel tasks that are executed and so on.... the above is just the first set of things we need to do :)

@oatkiller
Copy link
Contributor

I believe this is a duplicate of https://github.com/elastic/security-team/issues/6769

@oatkiller
Copy link
Contributor

@MadameSheema Are you OK to close this in favor of https://github.com/elastic/security-team/issues/6769 ?

@MikePaquette MikePaquette removed the epic label Jul 10, 2023
@MadameSheema
Copy link
Member Author

Hey @oatkiller I believe there are some tasks/efforts here that are not tracked in the shared ticket, can we include this ticket as part of the tasks? The first agreement I had with Kibana operations about having our tests enabled in every PR was to first stabilize Cypress and the first milestones were explained above.

@banderror banderror assigned maximpn and unassigned banderror Sep 11, 2023
@VidhiRambhia
Copy link
Contributor

Hi Team,

I am interested in addressing these open items. Is 'Improve test execution (each parallel task should be executed in less than 40min)' actively being worked on?

MadameSheema added a commit that referenced this issue Dec 11, 2023
…` team (#173024)

## Summary

This PR is part of the effort we are making to have our cypres
serverless tests ready for the second quality gate (QA environment -
real serverless project and also part of the initial effort started by
#153664.

With the introduced changes, we are creating specific Entity Analytics
executions for both ESS and serverless with the aim of:
- To help to identify quickly the ownership of the tests in case of
failure.
- To help to raise specific flakiness inside the tests of the team. 

In this PR:
- We are creating different executions for ESS, serverless and the
quality gate
- We are integrating everything with buildkite and also adding the new
executions to the flaky test suite runner
- We are updating the readme
- We are removing the overall `Security Solution` execution.
@MadameSheema
Copy link
Member Author

Closing in favour of: #173508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11 candidate performance Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture test_ui_functional test
Projects
None yet
Development

No branches or pull requests