Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Shared api query schema - Remove fields from QuerySchema #153472

Closed
Tracked by #153396
dominiqueclarke opened this issue Mar 22, 2023 · 1 comment · Fixed by #158363 or #158449
Closed
Tracked by #153396

[Synthetics] Shared api query schema - Remove fields from QuerySchema #153472

dominiqueclarke opened this issue Mar 22, 2023 · 1 comment · Fixed by #158363 or #158449
Assignees
@shahzad31
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@dominiqueclarke
Copy link
Contributor

QuerySchema in https://github.com/elastic/kibana/blob/main/x-pack/plugins/synthetics/server/routes/common.ts#L29 is shared by a few Synthetics HTTP apis.

To prepare for serverless, we must isolate SO attributes from HTTP interfaces.

To account for this change, we should remove fields which directly references SO fields, from this QuerySchema.

Helper functions that rely on fields should have their fields passed server-side. We should not depend on fields being passed from the client, or allow the client to pass arbitrary fields.
@dominiqueclarke dominiqueclarke added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke mentioned this issue Mar 22, 2023
Closed
@shahzad31 shahzad31 self-assigned this May 24, 2023
@shahzad31 shahzad31 mentioned this issue May 24, 2023
Merged
@shahzad31 shahzad31 mentioned this issue May 25, 2023
Merged
shahzad31 added a commit that referenced this issue May 25, 2023
@shahzad31
[Synthetics] Remove fields from API query interface (#158449)
97a93b3 
## Summary

Remove fields from API query interface !!

Fixes #153472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzad31 shahzad31

Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
3 participants
@shahzad31 @dominiqueclarke @elasticmachine