Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] - Update the AlertSummary to show only the rule-specific fields #153095

Closed
Tracked by #150854
fkanout opened this issue Mar 10, 2023 · 1 comment · Fixed by #153223
Closed
Tracked by #150854

[AO] - Update the AlertSummary to show only the rule-specific fields #153095

fkanout opened this issue Mar 10, 2023 · 1 comment · Fixed by #153223
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Mar 10, 2023 •
edited
Loading

🗒️ Summary

Part of #150854
Part of #145117

Related to #153103

Figma file

Starting from v8.8, we are updating the AlertSummary to show only the rule-specific fields. And the basic/shared fields across the rule types will be part of the header.

Before:

Screenshot 2023-03-10 at 12 41 27

After:

Screenshot 2023-03-10 at 12 44 15

✅ AC

  • Remove the shared fields across rule types
  • Keep using the callback function that uses to fill up the rule-specific fields
  • Update the design
  • Update the value field to accept component
@fkanout fkanout added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Mar 10, 2023
@fkanout fkanout self-assigned this Mar 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

This was referenced Mar 10, 2023
Closed
Closed
@fkanout fkanout changed the title [AO] - Update the AlertSummary to show only the rule-specific fields and remove [AO] - Update the AlertSummary to show only the rule-specific fields Mar 10, 2023
@fkanout fkanout mentioned this issue Mar 15, 2023
Merged
fkanout added a commit that referenced this issue Mar 21, 2023
@fkanout
[AO] - Update the design of the Alert Details header and summary (#15…
9e1342d 
…3223)

## Summary
It fixes #153095 and fixes #153103 by applying the new design.
### Before
<img width="1086" alt="Screenshot 2023-03-15 at 16 26 40"
src="https://user-images.githubusercontent.com/6838659/225358581-a602256b-2fa8-4355-8d32-dd141cb2f484.png">

### After
<img width="1032" alt="Screenshot 2023-03-15 at 16 15 20"
src="https://user-images.githubusercontent.com/6838659/225357766-30e8263e-ef19-41c3-8e67-8d1acffdbe7d.png">

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AO] - Update the design of the Alert Details header and summary fkanout/kibana
2 participants
@fkanout @elasticmachine