Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Restructure API integration tests based on their required license type #151877

Open
2 of 5 tasks
Tracked by #153633
xcrzx opened this issue Feb 22, 2023 · 2 comments
Open
2 of 5 tasks
Tracked by #153633

[Security Solution] Restructure API integration tests based on their required license type #151877

xcrzx opened this issue Feb 22, 2023 · 2 comments
Labels
8.13 candidate refactoring Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test test-api-integration

Comments

@xcrzx
Copy link
Contributor

xcrzx commented Feb 22, 2023 •
edited by banderror
Loading

Summary

Currently, the integration tests in the Security Solution are divided into two groups based on the license type:

  • x-pack/test/detection_engine_api_integration/basic - These tests are executed against a Kibana set-up with the Basic license.
  • x-pack/test/detection_engine_api_integration/security_and_spaces - These tests are executed against a Kibana set-up with the trial (Platinum) license.

Most of the tests are included in the security_and_spaces group, but some tests are also copied to the basic group. There is no clear distinction between the two groups, so developers generally add tests to the second group by default.

To improve the organization of the tests, we need to take the following actions:

  • Remove any duplicate tests.
  • Move any features not requiring a Platinum license to the basic group (which should be the case for most Security Solution features).
  • For features that require a Platinum license, we should test that they are not accessible with the basic license in the basic group, and we should test that they work correctly in the security_and_spaces group.

For reference, features by license: https://www.elastic.co/subscriptions

Detection Engine
Preview Give feedback
  1. [Detection Engine][MKI] Audit alerts FTRs in prep for MKI #179211
    Team:Detection Engine backport:skip release_note:skip v8.14.0
    yctercero
  2. [Detection Engine][FTR] Audit DE exceptions tests #179706
    Team:Detection Engine backport:skip release_note:skip v8.14.0
    yctercero

Rule Management
Preview Give feedback
No tasks being tracked yet.
@xcrzx xcrzx added technical debt Improvement of the software architecture and operational architecture Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team 8.8 candidate labels Feb 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx mentioned this issue Feb 22, 2023
Merged
3 tasks
@banderror banderror changed the title [Security Solution] Regroup integrational tests based on their required license type [Security Solution] Regroup API integration tests based on their required license type Mar 23, 2023
@banderror banderror added the test-coverage issues & PRs for improving code test coverage label Mar 23, 2023
@banderror banderror changed the title [Security Solution] Regroup API integration tests based on their required license type [Security Solution] Restructure API integration tests based on their required license type Mar 23, 2023
@banderror banderror mentioned this issue Mar 24, 2023
Open
@banderror banderror added test refactoring test-api-integration and removed test-coverage issues & PRs for improving code test coverage labels Mar 24, 2023
@banderror banderror self-assigned this Mar 24, 2023
@banderror banderror removed their assignment May 16, 2023
@banderror banderror self-assigned this May 23, 2023
@yctercero yctercero mentioned this issue Jan 29, 2024
Merged
@yctercero yctercero mentioned this issue Mar 22, 2024
Merged
yctercero added a commit that referenced this issue Mar 28, 2024
@yctercero
[Detection Engine][MKI] Audit alerts FTRs in prep for MKI (#179211)
7698d9c 
## Summary

Begins work on #169185 and
#151877 .

Related to #151877 this PR:
- Moves FTR tests under the `/alerts` folder that do not require
Platinum license into the basics folder. Tests in
`/alerts/trial_license_complete_tier` folder should now relate to
functionality that requires the higher license tier.
- Rearranged some of the folder structure so that it was clear what the
intent of the tests is
- Makes note of any issues in tickets that we will need to follow up on

Related to #169185 this PR:
- Ensures that tests are properly tagged for ESS & serverless
- Ensures none of the tests that are critical contain the `@skipInQA`
tag
This was referenced Mar 29, 2024
Merged
Draft
yctercero added a commit that referenced this issue Apr 2, 2024
@yctercero
[Detection Engine][FTR] Audit DE exceptions tests (#179706)
9215efb 
## Summary

Continues work on #169185 and
#151877 . There wasn't a ton of
folder restructure, just switching the tests to run on basic
license/essentials tier and some test renaming for clarity sake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.13 candidate refactoring Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test test-api-integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xcrzx @banderror @yctercero @WafaaNasr @elasticmachine