Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Fix flakey test in CaseViewPage component #151845

Closed
js-jankisalvi opened this issue Feb 22, 2023 · 2 comments
Closed

[Cases] Fix flakey test in CaseViewPage component #151845

js-jankisalvi opened this issue Feb 22, 2023 · 2 comments
Assignees
@js-jankisalvi
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@js-jankisalvi
Copy link
Contributor

Fix a flakey test skipped in this PR: #149396
@js-jankisalvi js-jankisalvi self-assigned this Feb 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 22, 2023
@js-jankisalvi js-jankisalvi added failed-test A test failure on a tracked branch, potentially flaky-test and removed test-failure-flaky needs-team Issues missing a team label labels Feb 22, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 22, 2023
@js-jankisalvi js-jankisalvi mentioned this issue Feb 22, 2023
Merged
6 tasks
@js-jankisalvi js-jankisalvi removed the needs-team Issues missing a team label label Feb 22, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 22, 2023
@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed needs-team Issues missing a team label labels Feb 22, 2023
@cnasikas cnasikas mentioned this issue Jun 25, 2023
Merged
2 tasks
cnasikas added a commit that referenced this issue Jun 27, 2023
@cnasikas
[Cases] Fix case view flaky tests (#160412)
c0047a1 
## Summary

This PR fixes flaky tests in
`x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx`.
Some of them were converted to an e2e test as they were too slow to be
on a unit test.

Successful runs: 

-
a4ed839
(50 times)
-
82ccceb
(45 times)
-
43c47e6
(20 times)

Fixes: #149775,
#149776,
#149777,
#149778,
#149779,
#149780,
#149781,
#149782,
#153335,
#153336,
#149773,
#149774,
#149772,
#149771,
#149770,
#149769,
#151845,
#153336,
#153335

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2500

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 27, 2023
@cnasikas
[Cases] Fix case view flaky tests (elastic#160412)
e9e3403 
## Summary

This PR fixes flaky tests in
`x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx`.
Some of them were converted to an e2e test as they were too slow to be
on a unit test.

Successful runs:

-
elastic@a4ed839
(50 times)
-
elastic@82ccceb
(45 times)
-
elastic@43c47e6
(20 times)

Fixes: elastic#149775,
elastic#149776,
elastic#149777,
elastic#149778,
elastic#149779,
elastic#149780,
elastic#149781,
elastic#149782,
elastic#153335,
elastic#153336,
elastic#149773,
elastic#149774,
elastic#149772,
elastic#149771,
elastic#149770,
elastic#149769,
elastic#151845,
elastic#153336,
elastic#153335

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2500

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit c0047a1)
@cnasikas
Copy link
Member

cnasikas commented Nov 2, 2023

Test is in x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts and is called should persist the draft of new comment while description is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js-jankisalvi js-jankisalvi

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cnasikas @elasticmachine @js-jankisalvi