[Dashboard] searchSessionId not updated when pinned filter changes

[nreese]

startDashboardSearchSessionIntegration dispatches setSearchSessionId when there is new query state. However, startDashboardSearchSessionIntegration uses getUnsavedChanges which uses dashboardDiffingFunctions to check for changes. dashboardDiffingFunctions removes pinned filters from the check since pinned filters are not part of application state.

https://github.com/elastic/kibana/blob/main/src/plugins/dashboard/public/dashboard_container/embeddable/integrations/search_sessions/start_dashboard_search_session_integration.ts#L128

    // listen to and compare states to determine when to launch a new session.
    this.getInput$()
      .pipe(pairwise(), debounceTime(CHANGE_CHECK_DEBOUNCE))
      .subscribe(async (states) => {
        const [previous, current] = states as DashboardContainerByValueInput[];
        const changes = await getUnsavedChanges.bind(this)(previous, current, refetchKeys);
        const shouldRefetch = Object.keys(changes).length > 0;
        if (!shouldRefetch) return;

        const {
          getState,
          dispatch,
          actions: { setSearchSessionId },
        } = this.getReduxEmbeddableTools();
        const currentSearchSessionId = getState().explicitInput.searchSessionId;

        const updatedSearchSessionId: string | undefined = (() => {
          // do not update session id if this is irrelevant state change to prevent excessive searches
          if (!shouldRefetch) return;

          let searchSessionIdFromURL = getSearchSessionIdFromURL();
          if (searchSessionIdFromURL) {
            if (session.isRestore() && session.isCurrentSession(searchSessionIdFromURL)) {
              // we had previously been in a restored session but have now changed state so remove the session id from the URL.
              removeSessionIdFromUrl();
              searchSessionIdFromURL = undefined;
            } else {
              session.restore(searchSessionIdFromURL);
            }
          }
          return searchSessionIdFromURL ?? session.start();
        })();

        if (updatedSearchSessionId && updatedSearchSessionId !== currentSearchSessionId) {
          dispatch(setSearchSessionId(updatedSearchSessionId));
        }
      });
});

https://github.com/elastic/kibana/blob/main/src/plugins/dashboard/public/dashboard_container/embeddable/integrations/diff_state/dashboard_diffing_functions.ts#L84

filters: ({ currentValue, lastValue }) =>
    compareFilters(
      currentValue.filter((f) => !isFilterPinned(f)),
      lastValue.filter((f) => !isFilterPinned(f)),
      COMPARE_ALL_OPTIONS
    ),

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)