Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the modelVersion API and types #150297

Closed
pgayvallet opened this issue Feb 6, 2023 · 0 comments · Fixed by #150149
Closed

Create the modelVersion API and types #150297

pgayvallet opened this issue Feb 6, 2023 · 0 comments · Fixed by #150149
Assignees
@pgayvallet
Labels
Epic:ZDTmigrations Zero downtime migrations Feature:Migrations Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

pgayvallet commented Feb 6, 2023 •
edited
Loading

Part of #150296

To be able to prepare the internal implementations and peform the changes required for managed upgrades, one of the first step is to add the API definition for SO model versioning.

This issue is just about adding the new API surface and types, not about its internal usage.

Given we'll be exposing an 'unwired' or 'unplugged' API, we should also adapt the registered types integration test to make sure we're informed in the unlikely scenario where a type owner was to use the API.
@pgayvallet pgayvallet self-assigned this Feb 6, 2023
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Migrations Epic:ZDTmigrations Zero downtime migrations labels Feb 6, 2023
This was referenced Feb 6, 2023
Closed
Merged
Closed
pgayvallet added a commit that referenced this issue Feb 7, 2023
@pgayvallet
Introduce the SO versionModel API (#150149)
7136039 
## Summary

Fix #150297

First step toward managed upgrades

This PR adds the types that will be used for the new SO model version
API, and adds the new properties to the `SavedObjectsType` type.

The implementation is outside of scope of the PR and will be implemented
in a future PR.

The PR also adapt the `check_registered_types` test to trigger a review
when the attributes of `SavedObjectsType` introduced in this PR are
changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
Epic:ZDTmigrations Zero downtime migrations Feature:Migrations Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce the SO versionModel API pgayvallet/kibana
1 participant
@pgayvallet