Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/discover_integration·ts - saved objects tagging - functional tests discover integration creating allows to create a tag from the tag selector #150249

Closed
kibanamachine opened this issue Feb 3, 2023 · 7 comments · Fixed by #155974
Closed

Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/discover_integration·ts - saved objects tagging - functional tests discover integration creating allows to create a tag from the tag selector #150249

kibanamachine opened this issue Feb 3, 2023 · 7 comments · Fixed by #155974
Assignees
@sebelga
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 3, 2023 •
edited
Loading

A test failed on a tracked branch

Error: retry.try timeout: Error: save modal still open
    at common_page.ts:471:15
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:68:21)
    at RetryService.try (retry.ts:31:12)
    at CommonPageObject.waitForSaveModalToClose (common_page.ts:469:5)
    at Context.<anonymous> (discover_integration.ts:138:9)
    at Object.apply (wrap_function.js:73:16)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.try (retry.ts:31:12)
    at CommonPageObject.waitForSaveModalToClose (common_page.ts:469:5)
    at Context.<anonymous> (discover_integration.ts:138:9)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 3, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 3, 2023
@nreese nreese added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Feb 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 8, 2023
@davismcphee davismcphee added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. :DataDiscovery/fix-it-week labels Feb 8, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kertal kertal self-assigned this Apr 27, 2023
@kertal kertal mentioned this issue Apr 27, 2023
Merged
1 task
kertal added a commit that referenced this issue Apr 28, 2023
@kertal
[Discover] Fix flaky saved objects tagging functional test (#155974)
e7a3a48 
This PR fixes #150249, an occasional flaky test of Discover's saved search tagging
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2179
@kibanamachine kibanamachine reopened this Sep 28, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Sep 28, 2023 •
edited
Loading

/skip

(9 failures across pull requests today)

@kibanamachine kibanamachine added blocker skipped-test Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.11.0 labels Sep 28, 2023
@kibanamachine
Copy link
Contributor Author

Skipped

main: 905dcfa

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

kibanamachine added a commit that referenced this issue Sep 28, 2023
@kibanamachine
skip failing test suite (#150249)
905dcfa
@kertal kertal removed :DataDiscovery/fix-it-week Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 4, 2023
@sebelga sebelga added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@kertal kertal removed their assignment Oct 16, 2023
@gsoldevila gsoldevila mentioned this issue Oct 30, 2023
Merged
gsoldevila added a commit that referenced this issue Oct 30, 2023
@gsoldevila
Address saved_object_tagging flakiness (#170114)
036918d 
## Summary

Fixes:
* #89958
* #150249
* #167812
* #167560

Uses same strategy as Stratoula's
[PR](#167599). It also adds a
"click" step to make sure the form control has the focus (as we do with
the other form controls on the same `fillForm` method).

The tests above fail cause the logic fails to clean the default tag
colour before entering a new one, resulting in:

![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)

Also fixes:
* #163817

[This
one](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)
is looks like a lost click on the Delete modal confirm button (modal
still present after 30s):


![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 30, 2023
@gsoldevila
Address saved_object_tagging flakiness (elastic#170114)
e3d5e65 
## Summary

Fixes:
* elastic#89958
* elastic#150249
* elastic#167812
* elastic#167560

Uses same strategy as Stratoula's
[PR](elastic#167599). It also adds a
"click" step to make sure the form control has the focus (as we do with
the other form controls on the same `fillForm` method).

The tests above fail cause the logic fails to clean the default tag
colour before entering a new one, resulting in:

![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)

Also fixes:
* elastic#163817

[This
one](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)
is looks like a lost click on the Delete modal confirm button (modal
still present after 30s):

![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)

(cherry picked from commit 036918d)
kibanamachine referenced this issue Oct 30, 2023
@kibanamachine @gsoldevila
[8.11] Address saved_object_tagging flakiness (#170114) (#170190)
c0bd227 
# Backport

This will backport the following commits from `main` to `8.11`:
- [Address saved_object_tagging flakiness
(#170114)](#170114)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-30T21:21:27Z","message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](#167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","test-failure-flaky","Team:SharedUX","backport:prev-minor","v8.12.0"],"number":170114,"url":"https://github.com/elastic/kibana/pull/170114","mergeCommit":{"message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](#167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170114","number":170114,"mergeCommit":{"message":"Address
saved_object_tagging flakiness (#170114)\n\n##
Summary\r\n\r\nFixes:\r\n*
https://github.com/elastic/kibana/issues/89958\r\n*
https://github.com/elastic/kibana/issues/150249\r\n*
https://github.com/elastic/kibana/issues/167812\r\n*
https://github.com/elastic/kibana/issues/167560\r\n\r\nUses same
strategy as
Stratoula's\r\n[PR](#167599). It
also adds a\r\n\"click\" step to make sure the form control has the
focus (as we do with\r\nthe other form controls on the same `fillForm`
method).\r\n\r\nThe tests above fail cause the logic fails to clean the
default tag\r\ncolour before entering a new one, resulting
in:\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/e753aa64-4132-4094-af01-c17d91223172)\r\n\r\nAlso
fixes:\r\n*
https://github.com/elastic/kibana/issues/163817\r\n\r\n[This\r\none](https://buildkite.com/elastic/kibana-on-merge/builds/36347#018b0068-ec42-47de-804d-b63a42b5b3e2)\r\nis
looks like a lost click on the Delete modal confirm button
(modal\r\nstill present after
30s):\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/25349407/b2025b45-5030-4b6a-95f9-58d77fd3d2ea)","sha":"036918d017c9d1ee20467f5ced9934f944d9ff00"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <[email protected]>
@gsoldevila
Copy link
Contributor

Hopefully fixed by #170114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebelga sebelga

Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Fix flaky saved objects tagging functional test kertal/kibana
8 participants
@nreese @kertal @sebelga @jbudz @elasticmachine @gsoldevila @davismcphee @kibanamachine