-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to add APM integration returns 404 #146312
Comments
Pinging @elastic/fleet (Team:Fleet) |
There is no The bundled version of APM in this environment would be available at |
@sqren could you help answer this? Now that the apmpackage is only bundled in Kibana, and not pushed to epr any longer. What would the correct link be? |
The APM button in the tutorial is non-versioned, it links to I just tried this on 8.6.0 BC3 on Cloud and everything worked fine. I'm not sure what the difference via Docker would be. |
As @jen-huang says, there's no hardcoded version in the link from APM (possibly elsewhere): kibana/x-pack/plugins/apm/public/tutorial/tutorial_fleet_instructions/index.tsx Lines 75 to 77 in e6ea551
|
It's a little hard to debug as I can't see the url bar, and can't determine where this goes wrong, and whether it's something APM is doing wrong. |
I'd need to know the url of the page where the integration is installed, and the url of the page that shows a 404 to determine if this is an issue on the APM side. |
@maryam-saeidi would you be able to share the URL you got please? |
@jlind23 @sqren I faced the issue during testing BC2(8.6.0) according to these steps, so I was testing it locally. Is this what you are looking for or do you mean the exact path? I can also try again with the latest BC to see if the issue still exists. I will share the exact URL after testing the lastest BC. |
@sqren This is the URL: |
@jen-huang could you please take a look again? @sqren 8.6 and 8.7 are not different so I would be surprised if this is coming from fleet. |
I could reproduce with 8.6 BC5 by following the steps as Mary mentioned here. I noticed that the API call I think this bug might be caused by #144343 which introduced the There is a workaround to install the package with API (that installs from bundled packages) and then open the
I also observed that locally the apm version returned is cc @hop-dev |
## Summary Fixes #146312 Fall back to bundled packages when loading package archive. Also fixed an issue with prerelease flag caused by #144431 Loading prerelease setting on Add/Edit integration page, so that it works well for cases where the url doesn't contain a concrete version like APM Steps to verify: - Start kibana locally, make sure that APM bundled package is there in `x-pack/plugins/fleet/target/bundled_packages` - Load http://localhost:5601/julia/app/integrations/detail/apm/overview (with default "beta integrations" off flag) - Expect that 8.6.0 version is showing up (or 8.7.0 depending on the build) - When clicking on Add Elastic APM, expect 8.6.0 to be loaded successfully <img width="1773" alt="image" src="https://user-images.githubusercontent.com/90178898/206482128-634ca823-bb21-46a9-a8b9-fc81d5dc126d.png"> Note: there is still a UI issue with loading assets on Overview page if the package is not in EPR. <img width="1747" alt="image" src="https://user-images.githubusercontent.com/90178898/206478275-ee8e9494-234f-44c8-88d9-a91c791b0196.png"> - switch "beta integrations" on on Integrations page - Open APM overview page again - expect `8.7.0-preview` version with the selector to change to last GA <img width="1100" alt="image" src="https://user-images.githubusercontent.com/90178898/206480986-2ed05b12-49e4-4c88-97c6-6cdf12f819da.png"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Fixes elastic#146312 Fall back to bundled packages when loading package archive. Also fixed an issue with prerelease flag caused by elastic#144431 Loading prerelease setting on Add/Edit integration page, so that it works well for cases where the url doesn't contain a concrete version like APM Steps to verify: - Start kibana locally, make sure that APM bundled package is there in `x-pack/plugins/fleet/target/bundled_packages` - Load http://localhost:5601/julia/app/integrations/detail/apm/overview (with default "beta integrations" off flag) - Expect that 8.6.0 version is showing up (or 8.7.0 depending on the build) - When clicking on Add Elastic APM, expect 8.6.0 to be loaded successfully <img width="1773" alt="image" src="https://user-images.githubusercontent.com/90178898/206482128-634ca823-bb21-46a9-a8b9-fc81d5dc126d.png"> Note: there is still a UI issue with loading assets on Overview page if the package is not in EPR. <img width="1747" alt="image" src="https://user-images.githubusercontent.com/90178898/206478275-ee8e9494-234f-44c8-88d9-a91c791b0196.png"> - switch "beta integrations" on on Integrations page - Open APM overview page again - expect `8.7.0-preview` version with the selector to change to last GA <img width="1100" alt="image" src="https://user-images.githubusercontent.com/90178898/206480986-2ed05b12-49e4-4c88-97c6-6cdf12f819da.png"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 24e2fcf)
#147335) # Backport This will backport the following commits from `main` to `8.6`: - [[Fleet] fix for apm not found in epr + prerelease flag (#147257)](#147257) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-12T10:06:50Z","message":"[Fleet] fix for apm not found in epr + prerelease flag (#147257)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/146312\r\n\r\nFall back to bundled packages when loading package archive.\r\n\r\nAlso fixed an issue with prerelease flag caused by\r\nhttps://github.com//pull/144431\r\n\r\nLoading prerelease setting on Add/Edit integration page, so that it\r\nworks well for cases where the url doesn't contain a concrete version\r\nlike APM\r\n\r\nSteps to verify:\r\n- Start kibana locally, make sure that APM bundled package is there in\r\n`x-pack/plugins/fleet/target/bundled_packages`\r\n- Load http://localhost:5601/julia/app/integrations/detail/apm/overview\r\n(with default \"beta integrations\" off flag)\r\n- Expect that 8.6.0 version is showing up (or 8.7.0 depending on the\r\nbuild)\r\n- When clicking on Add Elastic APM, expect 8.6.0 to be loaded\r\nsuccessfully\r\n\r\n<img width=\"1773\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206482128-634ca823-bb21-46a9-a8b9-fc81d5dc126d.png\">\r\n\r\nNote: there is still a UI issue with loading assets on Overview page if\r\nthe package is not in EPR.\r\n\r\n<img width=\"1747\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206478275-ee8e9494-234f-44c8-88d9-a91c791b0196.png\">\r\n\r\n- switch \"beta integrations\" on on Integrations page\r\n- Open APM overview page again\r\n- expect `8.7.0-preview` version with the selector to change to last GA\r\n\r\n<img width=\"1100\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206480986-2ed05b12-49e4-4c88-97c6-6cdf12f819da.png\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"24e2fcf47014d937a5019d83b95565a010ae4e22","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.6.0","v8.7.0"],"number":147257,"url":"https://github.com/elastic/kibana/pull/147257","mergeCommit":{"message":"[Fleet] fix for apm not found in epr + prerelease flag (#147257)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/146312\r\n\r\nFall back to bundled packages when loading package archive.\r\n\r\nAlso fixed an issue with prerelease flag caused by\r\nhttps://github.com//pull/144431\r\n\r\nLoading prerelease setting on Add/Edit integration page, so that it\r\nworks well for cases where the url doesn't contain a concrete version\r\nlike APM\r\n\r\nSteps to verify:\r\n- Start kibana locally, make sure that APM bundled package is there in\r\n`x-pack/plugins/fleet/target/bundled_packages`\r\n- Load http://localhost:5601/julia/app/integrations/detail/apm/overview\r\n(with default \"beta integrations\" off flag)\r\n- Expect that 8.6.0 version is showing up (or 8.7.0 depending on the\r\nbuild)\r\n- When clicking on Add Elastic APM, expect 8.6.0 to be loaded\r\nsuccessfully\r\n\r\n<img width=\"1773\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206482128-634ca823-bb21-46a9-a8b9-fc81d5dc126d.png\">\r\n\r\nNote: there is still a UI issue with loading assets on Overview page if\r\nthe package is not in EPR.\r\n\r\n<img width=\"1747\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206478275-ee8e9494-234f-44c8-88d9-a91c791b0196.png\">\r\n\r\n- switch \"beta integrations\" on on Integrations page\r\n- Open APM overview page again\r\n- expect `8.7.0-preview` version with the selector to change to last GA\r\n\r\n<img width=\"1100\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206480986-2ed05b12-49e4-4c88-97c6-6cdf12f819da.png\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"24e2fcf47014d937a5019d83b95565a010ae4e22"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147257","number":147257,"mergeCommit":{"message":"[Fleet] fix for apm not found in epr + prerelease flag (#147257)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/146312\r\n\r\nFall back to bundled packages when loading package archive.\r\n\r\nAlso fixed an issue with prerelease flag caused by\r\nhttps://github.com//pull/144431\r\n\r\nLoading prerelease setting on Add/Edit integration page, so that it\r\nworks well for cases where the url doesn't contain a concrete version\r\nlike APM\r\n\r\nSteps to verify:\r\n- Start kibana locally, make sure that APM bundled package is there in\r\n`x-pack/plugins/fleet/target/bundled_packages`\r\n- Load http://localhost:5601/julia/app/integrations/detail/apm/overview\r\n(with default \"beta integrations\" off flag)\r\n- Expect that 8.6.0 version is showing up (or 8.7.0 depending on the\r\nbuild)\r\n- When clicking on Add Elastic APM, expect 8.6.0 to be loaded\r\nsuccessfully\r\n\r\n<img width=\"1773\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206482128-634ca823-bb21-46a9-a8b9-fc81d5dc126d.png\">\r\n\r\nNote: there is still a UI issue with loading assets on Overview page if\r\nthe package is not in EPR.\r\n\r\n<img width=\"1747\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206478275-ee8e9494-234f-44c8-88d9-a91c791b0196.png\">\r\n\r\n- switch \"beta integrations\" on on Integrations page\r\n- Open APM overview page again\r\n- expect `8.7.0-preview` version with the selector to change to last GA\r\n\r\n<img width=\"1100\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/90178898/206480986-2ed05b12-49e4-4c88-97c6-6cdf12f819da.png\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"24e2fcf47014d937a5019d83b95565a010ae4e22"}}]}] BACKPORT--> Co-authored-by: Julia Bardi <[email protected]>
Kibana version: 8.6.0-SNAPSHOT
Elasticsearch version: 8.6.0-SNAPSHOT
Original install method (e.g. download page, yum, from source, etc.): Docker
Describe the bug:
On a fresh cluster, when trying to add an APM Integration a
404
is reported.Installing directly via Settings works, while it indicates that 0 assets would be installed.
Steps to reproduce:
@maryam-saeidi shared a screencast describing the problem:
https://user-images.githubusercontent.com/5555349/203823955-c9039f81-6e1c-46a4-8f83-4ce064d86130.mov
Workaround via installing from Settings shows:
Expected behavior:
The APM integration is already packaged with Kibana, it should be loaded from there.
Additional notes:
Could this be related to the version rewrite that happens on pre-release builds when packaging the APM integration with Kibana?
The text was updated successfully, but these errors were encountered: