Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest 29 upgrade skipped test - x-pack/plugins/stack_connectors/public/connector_types/stack/es_index/es_index_connector.test.tsx #145751

Closed
jbudz opened this issue Nov 18, 2022 · 1 comment · Fixed by #147311
Closed

Jest 29 upgrade skipped test - x-pack/plugins/stack_connectors/public/connector_types/stack/es_index/es_index_connector.test.tsx #145751

jbudz opened this issue Nov 18, 2022 · 1 comment · Fixed by #147311
Labels
blocker skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0

Comments

@jbudz
Copy link
Member

jbudz commented Nov 18, 2022

x-pack/plugins/stack_connectors/public/connector_types/stack/es_index/es_index_connector.test.tsx was skipped during the upgrade to Jest 29

#143319 (comment)

● IndexActionConnectorFields › Validation › connector validation succeeds when connector config is valid

    expect(jest.fn()).toBeCalledWith(...expected)

    - Expected
    + Received

      Object {
    -   "data": Object {
    -     "__internal__": Object {
    -       "hasTimeFieldCheckbox": true,
    -     },
    -     "actionTypeId": ".index",
    -     "config": Object {
    -       "executionTimeField": "1",
    -       "index": "test_es_index",
    -       "refresh": false,
    -     },
    -     "id": "test",
    -     "isDeprecated": false,
    -     "name": "es_index",
    -   },
    -   "isValid": true,
    +   "data": Object {},
    +   "isValid": undefined,
      },

Apologies for the skip. This was only merged into 8.7.0 and we're hoping there's enough lead time to triage.
@jbudz jbudz added blocker skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0 labels Nov 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@jbudz jbudz mentioned this issue Nov 18, 2022
Merged
@cnasikas cnasikas mentioned this issue Dec 9, 2022
Merged
2 tasks
cnasikas added a commit that referenced this issue Dec 13, 2022
@cnasikas @kibanamachine
[Connectors] Unskip a test for the es index connector (#147311)
26e6641 
## Summary

This PR unskips a test that was skipped during the [Jest
upgrade](#143319) to version 29.

Fixes #145751

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <[email protected]>
nreese pushed a commit to nreese/kibana that referenced this issue Dec 16, 2022
@cnasikas @kibanamachine @nreese
[Connectors] Unskip a test for the es index connector (elastic#147311)
9fac0d4 
## Summary

This PR unskips a test that was skipped during the [Jest
upgrade](elastic#143319) to version 29.

Fixes elastic#145751

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Connectors] Unskip a test for the es index connector cnasikas/kibana
2 participants
@jbudz @elasticmachine