Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Refactor log stream page query state #145133

Closed
Tracked by #134412
weltenwort opened this issue Nov 14, 2022 · 1 comment · Fixed by #146884
Closed
Tracked by #134412

[Logs UI] Refactor log stream page query state #145133

weltenwort opened this issue Nov 14, 2022 · 1 comment · Fixed by #146884
Assignees
@weltenwort
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Nov 14, 2022 •
edited
Loading

📓 Summary

In order for the query state management to play well with the page state machine, we want the query state to be managed by a dedicated machine that is spawned by the page state machine in the hasLogView state.

✔️ Acceptance criteria

  • The query state is managed by a state machine.
  • The state machine syncs the query to the query string service.
  • The state machine syncs the query to the url.
  • The hasLogViewIndices state waits for the initial query (from url and service) until it transitions to initialized.
  • An adapter provider makes data from the query machine's context available to the log stream page components.

💡 Implementation hints

image
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

This was referenced Nov 14, 2022
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 2, 2022
Merged
Merged
@weltenwort weltenwort self-assigned this Dec 29, 2022
weltenwort added a commit that referenced this issue Jan 3, 2023
@weltenwort
[Logs UI] Refactor log stream query state (#146884)
46d6892 
Co-authored-by: Kerry Gallagher <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
closes #145133
closes #142764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs UI] Refactor log stream query state weltenwort/kibana
2 participants
@weltenwort @elasticmachine