Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Monitor details - Some queries not properly filtered for location #144857

Closed
dominiqueclarke opened this issue Nov 8, 2022 · 2 comments · Fixed by #144873
Closed

[Synthetics] Monitor details - Some queries not properly filtered for location #144857

dominiqueclarke opened this issue Nov 8, 2022 · 2 comments · Fixed by #144873
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0

Comments

@dominiqueclarke
Copy link
Contributor

Some queries on the Monitor details page are not properly filtered for location. This page displays monitor details for a location that is offline, yet it still has data.

Screen Shot 2022-11-08 at 5 02 21 PM

Screen Shot 2022-11-08 at 5 02 30 PM

Steps to reproduce:

  1. When running locally, you can create monitor against US Central QA and US Central Dev
  2. Navigate to the monitors detail page for US Central QA
  3. Despite US Central QA being offline, some visualizations are popualted
@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0 labels Nov 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke mentioned this issue Nov 9, 2022
Merged
@dominiqueclarke dominiqueclarke self-assigned this Nov 9, 2022
shahzad31 pushed a commit that referenced this issue Nov 10, 2022
@dominiqueclarke
[Synthetics] filter by location for monitor details visualizations (#…
0cae7ed 
…144873)

Resolves #144857
@afgomez afgomez mentioned this issue Nov 17, 2022
Merged
afgomez pushed a commit that referenced this issue Nov 17, 2022
[Synthetics UI] Filter history stats by location (#145515)
ce1ec31 
## Summary

Related to #144857. Ensure the stats in the history page also take into
account the monitor location.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 17, 2022
[Synthetics UI] Filter history stats by location (elastic#145515)
3ad7d37 
## Summary

Related to elastic#144857. Ensure the stats in the history page also take into
account the monitor location.

(cherry picked from commit ce1ec31)
kibanamachine added a commit that referenced this issue Nov 17, 2022
@kibanamachine
[8.6] [Synthetics UI] Filter history stats by location (#145515) (#14…
2f2d4af 
…5550)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Synthetics UI] Filter history stats by location
(#145515)](#145515)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Gómez","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T12:10:19Z","message":"[Synthetics
UI] Filter history stats by location (#145515)\n\n##
Summary\r\n\r\nRelated to #144857. Ensure the stats in the history page
also take into\r\naccount the monitor
location.","sha":"ce1ec3178d1c329fe287d49cfc03681682f89b79","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.6.0","v8.7.0"],"number":145515,"url":"https://github.com/elastic/kibana/pull/145515","mergeCommit":{"message":"[Synthetics
UI] Filter history stats by location (#145515)\n\n##
Summary\r\n\r\nRelated to #144857. Ensure the stats in the history page
also take into\r\naccount the monitor
location.","sha":"ce1ec3178d1c329fe287d49cfc03681682f89b79"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145515","number":145515,"mergeCommit":{"message":"[Synthetics
UI] Filter history stats by location (#145515)\n\n##
Summary\r\n\r\nRelated to #144857. Ensure the stats in the history page
also take into\r\naccount the monitor
location.","sha":"ce1ec3178d1c329fe287d49cfc03681682f89b79"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Gómez <[email protected]>
@awahab07 awahab07 assigned awahab07 and unassigned dominiqueclarke Nov 18, 2022
@awahab07
Copy link
Contributor

Post FF Testing

Tested and the visualizations on History page now correctly filter the data based on selected location.

Found another issue related to the Location Selector, tracked here #145758.

@awahab07 awahab07 removed their assignment Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Synthetics] filter by location for monitor details visualizations dominiqueclarke/kibana
3 participants
@awahab07 @dominiqueclarke @elasticmachine