Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Guided onboarding] Dropdown panel incorrect width #144766

Closed
alisonelizabeth opened this issue Nov 8, 2022 · 1 comment · Fixed by #144790
Closed

[Guided onboarding] Dropdown panel incorrect width #144766

alisonelizabeth opened this issue Nov 8, 2022 · 1 comment · Fixed by #144790
Assignees
@cindychangy
Labels
bug Fixes for quality problems that affect the customer experience Team:Journey/Onboarding Platform Journey Onboarding team

Comments

@alisonelizabeth
Copy link
Contributor

The dropdown panel is no longer rendering as expected. Possibly caused by #141279.

Screen Shot 2022-11-07 at 8 25 04 PM
@alisonelizabeth alisonelizabeth added bug Fixes for quality problems that affect the customer experience Team:Journey/Onboarding Platform Journey Onboarding team labels Nov 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@alisonelizabeth alisonelizabeth mentioned this issue Nov 8, 2022
Merged
@cindychangy cindychangy mentioned this issue Nov 8, 2022
Merged
cindychangy added a commit that referenced this issue Nov 9, 2022
@cindychangy
[Guided Onboarding] Dropdown panel width fix (#144790)
785833c 
## Summary

This resolves [issue
#144766](#144766), the latest
EUI upgrade breaks the panel width. The reason is the following:
![Group
625](https://user-images.githubusercontent.com/11224465/200543746-d3f65af3-b994-49fd-9b1e-9e2a7ef5d881.png)

I have changed the `width` attribute to `inline-size` to overwrite this,
I also added `wrap` on the footer items, I think it was initially
discussed not to add it, but looking at it again, I think it would be
safer to add so that if someone is by chance using a very small
screen/device the footer will appear properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindychangy cindychangy

Labels
bug Fixes for quality problems that affect the customer experience Team:Journey/Onboarding Platform Journey Onboarding team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Guided Onboarding] Dropdown panel width fix cindychangy/kibana
3 participants
@alisonelizabeth @cindychangy @elasticmachine