Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps] backport to 7.17 fix for: "event.duration" must be a safe number #143562

Closed
pmuellr opened this issue Oct 18, 2022 · 1 comment · Fixed by #144837
Closed

[ResponseOps] backport to 7.17 fix for: "event.duration" must be a safe number #143562

pmuellr opened this issue Oct 18, 2022 · 1 comment · Fixed by #144837
Assignees
@mikecote
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:EventLog Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Oct 18, 2022

We originally reported a problem with JSON numbers which are too large, in #127802 . This got fixed in #130819, but was not backported to 7.17.

Currently the backport --dryRun shows 11 files in conflict, for a direct backport of that PR to 7.17.
@pmuellr pmuellr added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:EventLog Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels Oct 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@doakalexi doakalexi moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Oct 20, 2022
@mikecote mikecote self-assigned this Nov 8, 2022
@mikecote mikecote moved this from Todo to In Progress in AppEx: ResponseOps - Execution & Connectors Nov 8, 2022
@mikecote mikecote mentioned this issue Nov 8, 2022
Merged
@mikecote mikecote moved this from In Progress to In Review in AppEx: ResponseOps - Execution & Connectors Nov 10, 2022
@mikecote mikecote linked a pull request Nov 10, 2022 that will close this issue
[7.x] Convert event log's duration from number to string in Kibana (keep as "long" in Elasticsearch) #144837
Merged
mikecote added a commit that referenced this issue Nov 10, 2022
@mikecote @kibanamachine
[7.x] Convert event log's duration from number to string in Kibana (k…
a1730fd 
…eep as "long" in Elasticsearch) (#144837)

Fixes #143562.

Backport of #130819 to `7.x`.

## Steps to verify

1. Fake alert event log durations to be 1 year by changing the following
code


>https://github.com/elastic/kibana/pull/144837/files#diff-27ff694dc534e9e509d43b00c563eabada722db2371c9bcf016ff3c8b929c5fbR706
>const duration = millisToNanos(31556926000);

2. Create a rule that creates an alert consistently (ex: index
threshold)

3. Let the rule run a few times

4. See event log now capturing long durations successfully

>curl -XGET
'https://elastic:changeme@localhost:9200/.kibana-event-log*/_search?pretty'
-k

Co-authored-by: Kibana Machine <[email protected]>
Repository owner moved this from In Review to Done in AppEx: ResponseOps - Execution & Connectors Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikecote mikecote

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:EventLog Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project
Milestone
No milestone
3 participants
@pmuellr @mikecote @elasticmachine