Alerts menu in discover main nav doesn't have darktheme #143070
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
:DataDiscovery/fix-it-week
Feature:Alerting
Feature:Discover
Discover Application
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Comments
bhavyarm
added
bug
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
added
impact:low
jughosta
added a commit
that referenced
this issue
Nov 17, 2022
Closes #143070 ## Summary This PR adds theme provider to the Alerts popover. Dark theme: <img width="534" alt="Screenshot 2022-11-16 at 16 37 49" src="https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png"> Light theme: <img width="531" alt="Screenshot 2022-11-16 at 16 38 17" src="https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png"> Co-authored-by: Matthias Wilhelm <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 17, 2022
Closes elastic#143070 ## Summary This PR adds theme provider to the Alerts popover. Dark theme: <img width="534" alt="Screenshot 2022-11-16 at 16 37 49" src="https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png"> Light theme: <img width="531" alt="Screenshot 2022-11-16 at 16 38 17" src="https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png"> Co-authored-by: Matthias Wilhelm <[email protected]> (cherry picked from commit e33392b)
kibanamachine
referenced
this issue
Nov 17, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [[Discover] Fix theme for Alerts popover (#145390)](#145390) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T21:32:39Z","message":"[Discover] Fix theme for Alerts popover (#145390)\n\nCloses https://github.com/elastic/kibana/issues/143070\r\n\r\n## Summary\r\n\r\nThis PR adds theme provider to the Alerts popover.\r\n\r\nDark theme:\r\n<img width=\"534\" alt=\"Screenshot 2022-11-16 at 16 37 49\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png\">\r\n\r\nLight theme:\r\n<img width=\"531\" alt=\"Screenshot 2022-11-16 at 16 38 17\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png\">\r\n\r\nCo-authored-by: Matthias Wilhelm <[email protected]>","sha":"e33392bff0a022bb246f8d560a336ebdac0555f9","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.7.0"],"number":145390,"url":"https://github.com/elastic/kibana/pull/145390","mergeCommit":{"message":"[Discover] Fix theme for Alerts popover (#145390)\n\nCloses https://github.com/elastic/kibana/issues/143070\r\n\r\n## Summary\r\n\r\nThis PR adds theme provider to the Alerts popover.\r\n\r\nDark theme:\r\n<img width=\"534\" alt=\"Screenshot 2022-11-16 at 16 37 49\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png\">\r\n\r\nLight theme:\r\n<img width=\"531\" alt=\"Screenshot 2022-11-16 at 16 38 17\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png\">\r\n\r\nCo-authored-by: Matthias Wilhelm <[email protected]>","sha":"e33392bff0a022bb246f8d560a336ebdac0555f9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145390","number":145390,"mergeCommit":{"message":"[Discover] Fix theme for Alerts popover (#145390)\n\nCloses https://github.com/elastic/kibana/issues/143070\r\n\r\n## Summary\r\n\r\nThis PR adds theme provider to the Alerts popover.\r\n\r\nDark theme:\r\n<img width=\"534\" alt=\"Screenshot 2022-11-16 at 16 37 49\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png\">\r\n\r\nLight theme:\r\n<img width=\"531\" alt=\"Screenshot 2022-11-16 at 16 38 17\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png\">\r\n\r\nCo-authored-by: Matthias Wilhelm <[email protected]>","sha":"e33392bff0a022bb246f8d560a336ebdac0555f9"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <[email protected]>
![https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png\">\r\n\r\nLight](https://user-images.githubusercontent.com/1415710/202226249-a46f6608-4f35-40ce-bfbf-847e9a7ba81a.png\">\r\n\r\nLight){kind=link}
![https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png\">\r\n\r\nCo-authored-by](https://user-images.githubusercontent.com/1415710/202226260-9e67a8dd-f6a4-40ff-ae28-2691b9a082bf.png\">\r\n\r\nCo-authored-by){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.5.0
Elasticsearch version: 8.5.0
Server OS version: darwin_x86_64
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: Alerts menu in discover main nav doesn't have darktheme.
The text was updated successfully, but these errors were encountered: