Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Use Unified Search Bar: support date picker #142767

Closed
Tracked by #142714 ...
Kerry350 opened this issue Oct 5, 2022 · 6 comments · Fixed by #144351
Closed
Tracked by #142714 ...

[Logs UI] Use Unified Search Bar: support date picker #142767

Kerry350 opened this issue Oct 5, 2022 · 6 comments · Fixed by #144351
Assignees
Labels
Feature:Discover Discover Application Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Kerry350
Copy link
Contributor

Kerry350 commented Oct 5, 2022

Summary

Please see this issue for high level overview: #142714

This issue can be implemented before major state refactoring efforts.

Implementation hints

Screenshot 2022-10-05 at 16 30 36

We have one extra requirement in the Log Explorer that requires some ✨ inventive ✨ thinking. We need to support a "Stream live" / "Stop streaming" button via the Unified Search Bar. We should be able to facilitate this via a custom submit button, which accepts any React node, and can be changed based on the boolean state.

Acceptance criteria

@Kerry350 Kerry350 added Feature:Discover Discover Application Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@weltenwort
Copy link
Member

On second thought that "live stream" button seems like it would be useful in addition to a "submit" button. Maybe it would also be feasible to put the whole bar into a flex row and just add the "live stream" button in a separate flex item on the right? 🤔

@miltonhultgren
Copy link
Contributor

Is this different from the "Refresh every X seconds" mode?

Screenshot 2022-10-06 at 17 50 31

@weltenwort
Copy link
Member

It's mostly identical, it just exposes it more prominently. And it has slightly different semantics because it also takes control of the scrolling.

@Kerry350
Copy link
Contributor Author

Kerry350 commented Oct 10, 2022

seems like it would be useful in addition to a "submit" button. Maybe it would also be feasible to put the whole bar into a flex row and just add the "live stream" button in a separate flex item on the right?

Just for context on this issue for others: we should keep both buttons. This flex composition would be one solution, or it may even be possible to have the prop pass through both buttons (since it accepts any React node), and just respond to the relevant callbacks.

Is this different from the "Refresh every X seconds" mode?

Not really, the stream live button is just in a different location with a fixed interval. I think historically (like, far back) the callbacks and props were also a little harder to work with, although that seems simpler now.

Edit: I guess from a "converge with Discover" standpoint Discover does offer "refresh every" so maybe we should use that 🤔

@weltenwort
Copy link
Member

weltenwort commented Oct 10, 2022

I guess from a "converge with Discover" standpoint Discover does offer "refresh every" so maybe we should use that

agreed, we should sync the date picker controls with it if we don't already. But given that "live tailing" is a core feature I still see value in exposing an easy-to-discover UI component to toggle that mode.

@weltenwort weltenwort self-assigned this Oct 20, 2022
weltenwort added a commit that referenced this issue Nov 9, 2022
This enables the date-picker of the unified search bar introduced into the Logs UI in #143222 and simultaneously removes the custom date picker.

closes #142767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants