Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/disable·ts - alerting api integration security and spaces enabled Alerts - Group 1 alerts disable space_1_all_alerts_none_actions at space1 should still be able to disable alert when AAD is broken #141849

Closed
kibanamachine opened this issue Sep 26, 2022 · 6 comments
Closed

Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/disable·ts - alerting api integration security and spaces enabled Alerts - Group 1 alerts disable space_1_all_alerts_none_actions at space1 should still be able to disable alert when AAD is broken #141849

kibanamachine opened this issue Sep 26, 2022 · 6 comments
Assignees
@ersin-erdal
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 26, 2022 •
edited
Loading

A test failed on a tracked branch

Error: expected true to sort of equal false
    at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/disable.ts:376:51)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: 'true',
  expected: 'false',
  showDiff: true
}

First failure: CI Build - 8.5
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Sep 26, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 26, 2022
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Sep 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 26, 2022
@mikecote mikecote moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Oct 6, 2022
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Oct 20, 2022

/skip

kibanamachine added a commit that referenced this issue Oct 20, 2022
@kibanamachine
skip failing test suite (#141849)
9a433da
@kibanamachine
Copy link
Contributor Author

Skipped

main: 9a433da

@ersin-erdal ersin-erdal self-assigned this Nov 3, 2022
@ersin-erdal ersin-erdal mentioned this issue Nov 7, 2022
Closed
@pmuellr pmuellr mentioned this issue Nov 16, 2022
Closed
@ymao1 ymao1 mentioned this issue Dec 20, 2022
Merged
ymao1 added a commit that referenced this issue Dec 21, 2022
@ymao1 @kibanamachine
[ResponseOps] Retry bulk update conflicts in task manager (#147808)
a6232c4 
Resolves #145316,
#141849,
#141864

## Summary

Adds a retry on conflict error to the saved objects bulk update call
made by task manager. Errors are returned by the saved object client
inside an array (with a success response). Previously, we were not
inspecting the response array, just returning the full data. With this
PR, we are inspecting the response array specifically for conflict
errors and retrying the update for just those tasks.

This `bulkUpdate` function is used both internally by task manager and
externally by the rules client. I default the number of retries to 0 for
bulk updates from the task manager in order to preserve existing
behavior (and in order not to increase the amount of time it takes for
task manager to run) but use 3 retries when used externally.

Also unskipped the two flaky disable tests and ran them through the
flaky test runner 400 times with no failures.
*
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1652
*
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1653
*
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1660
*
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1661

Co-authored-by: Kibana Machine <[email protected]>
@ymao1
Copy link
Contributor

ymao1 commented Dec 21, 2022

Fixed with #147808

@ymao1 ymao1 closed this as completed Dec 21, 2022
Repository owner moved this from In Progress to Done in AppEx: ResponseOps - Execution & Connectors Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ersin-erdal ersin-erdal

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] flaky bulk disable task test ersin-erdal/kibana
5 participants
@jbudz @ymao1 @elasticmachine @kibanamachine @ersin-erdal