Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability] Alerts page > filter does not work #140573

Closed
Tracked by #145991
maryam-saeidi opened this issue Sep 13, 2022 · 6 comments
Closed
Tracked by #145991

[Actionable Observability] Alerts page > filter does not work #140573

maryam-saeidi opened this issue Sep 13, 2022 · 6 comments
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 v8.9.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Sep 13, 2022

Summary

In the alerts page, filters are not working, in the code, we only handle query and time range but not filters.

Screen Recording 2022-09-13 at 09 26 03 AM

Acceptance Criteria

  • Implement filter functionality on the alerts page
  • Filters should be saved in the URL similar to discover

Check this ticket for an implementation hint: #116135

@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 labels Sep 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi
Copy link
Member Author

This can be related: #116135

@maryam-saeidi
Copy link
Member Author

maryam-saeidi commented Feb 8, 2023

Based on a discussion with Katrin:

  • We want to adopt the filter but not the saved query at the moment.

@CoenWarmer
Copy link
Contributor

Short term fix would be to just disable the filter button in the Unified Search component in this context. Then in a follow up ticket re-enable it and actually handle it properly

@maryam-saeidi
Copy link
Member Author

maryam-saeidi commented Apr 20, 2023

@CoenWarmer Filters are already hidden on the main.

@fkanout fkanout added the v8.9.0 label Jun 7, 2023
@maryam-saeidi maryam-saeidi removed the bug Fixes for quality problems that affect the customer experience label Jun 7, 2023
@maryam-saeidi
Copy link
Member Author

This issue was previously a bug, but after the work on the shareable alert search bar, I made filters hidden.

Now the question is whether we want to introduce the filters again or not, which does not seem to be a high priority at the moment and is a different question from the original bug.

As a result, I discussed it with @katrin-freihofner, and we decided to close this ticket and open a new one if we wanted to have filters on the alert details page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 v8.9.0
Projects
None yet
Development

No branches or pull requests

6 participants