Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use _force_synthetic_source instead of fakeSyntheticSource #140255

Closed
dgieselaar opened this issue Sep 8, 2022 · 4 comments · Fixed by #144300
Closed

[APM] Use _force_synthetic_source instead of fakeSyntheticSource #140255

dgieselaar opened this issue Sep 8, 2022 · 4 comments · Fixed by #144300
Assignees
@kpatticha
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.5.0 v8.6.0

Comments

@dgieselaar
Copy link
Member

dgieselaar commented Sep 8, 2022 •
edited
Loading

We currently simulate synthetic source for metric documents by flattening and de-flattening _source. This is to get more guarantees about our UI being synthetic source-compatible. However, there is a better way to do this: Elasticsearch supports a force_synthetic_source query parameter that enforces re-hydration of _source in Elasticsearch. We should replace our usage of fakeSyntheticSource with this query parameter. It's probably best to set it behind a config parameter that we can enable in our API tests so it doesn't inadvertently break anything for our users.
@dgieselaar dgieselaar added the Team:APM All issues that need APM UI Team support label Sep 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@sorenlouv sorenlouv mentioned this issue Oct 11, 2022
Merged
@sorenlouv
Copy link
Member

Reverted in #143027

dgieselaar added a commit to dgieselaar/kibana that referenced this issue Nov 1, 2022
@dgieselaar
[APM] Use force_synthetic_source in API tests
242ae64 
Closes elastic#140255.
@dgieselaar dgieselaar mentioned this issue Nov 1, 2022
Merged
@dgieselaar dgieselaar self-assigned this Nov 1, 2022
@kpatticha
Copy link
Contributor

As the change was reverted, should we remove the test label?

@dgieselaar
Copy link
Member Author

@kpatticha the revert concerned a Kibana-side mock implementation of synthetic source. We moved to using the _force_synthetic_source ES query parameter in #144300

@kpatticha kpatticha self-assigned this Nov 28, 2022
@kpatticha kpatticha added the apm:test-plan-done Pull request that was successfully tested during the test plan label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpatticha kpatticha

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Use force_synthetic_source in API tests dgieselaar/kibana
5 participants
@dannycroft @sorenlouv @dgieselaar @kpatticha @elasticmachine