Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability] Add time range filter to Alerts Summary Widget #139489

Closed
Tracked by #137196
fkanout opened this issue Aug 25, 2022 · 2 comments · Fixed by #147253
Closed
Tracked by #137196

[Actionable Observability] Add time range filter to Alerts Summary Widget #139489

fkanout opened this issue Aug 25, 2022 · 2 comments · Fixed by #147253
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 v8.7.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Aug 25, 2022

📝 Summary

The Alerts Summary Widget will be integrated into other pages/hosts (not only the Rule Details page). Some of these pages have time range filter capabilities. The Alerts Summary Widget should apply the time range filters provided by the host page to guarantee consistency.

✅ AC

  • Currently, the Alerts Summary Widget has a hardcoded time range filter 30days. And it should be kept as the default value.
  • Expose an optionalprop for Alerts Summary Widget that accepts { start: number, end: number } for the time range
  • The prop should update the Alert Summary Widget leading hook where it will override the default query in these two lines
  • The selected time range should be mentioned in the widget interface, instead of the last 30-day alerts

cc @simianhacker

@fkanout fkanout added the v8.5.0 label Aug 25, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 25, 2022
@fkanout fkanout added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Aug 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi
Copy link
Member

@fkanout I implemented this ticket a bit differently from the acceptance criteria:

Currently, the Alerts Summary Widget has a hardcoded time range filter 30days. And it should be kept as the default value.

I didn't use the default value since we need to pass absolute time to the new API and it was not clear when we need to generate the absolute time. I decided to put this responsibility to the consumer to decide when to update the absolute time range.

Expose an optionalprop for Alerts Summary Widget that accepts { start: number, end: number } for the time range

The selected time range should be mentioned in the widget interface, instead of the last 30-day alerts

I used { utcFrom: string, utcTo: string, title: JSX.Element | string } to make it more explicit that we need to provide the time in UTC format, in the new API, it only accepts this format. I also allowed consumer to decide whether to have a title for Alert Summary Widget or not.

Please let me know if there is any concern.

maryam-saeidi added a commit that referenced this issue Dec 14, 2022
)

Resolves #139489

## 📝 Summary

Allow time range filter to be provided by consumer for Alert Summary
Widget.

## 🧪 How to test

The functionality of the Alert Summary Widget has not been changed, so
Alert Summary Widget should have the same information as before. You can
check if the numbers that you see in the widget match the number of
alerts in the alert table.

Co-authored-by: Kevin Delemme <[email protected]>
nreese pushed a commit to nreese/kibana that referenced this issue Dec 16, 2022
…tic#147253)

Resolves elastic#139489

## 📝 Summary

Allow time range filter to be provided by consumer for Alert Summary
Widget.

## 🧪 How to test

The functionality of the Alert Summary Widget has not been changed, so
Alert Summary Widget should have the same information as before. You can
check if the numbers that you see in the widget match the number of
alerts in the alert table.

Co-authored-by: Kevin Delemme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 v8.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants