Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Rules imported successfully when there is no uploaded rule #139450

Closed
ghost opened this issue Aug 25, 2022 · 7 comments
Closed

[Security Solution] Rules imported successfully when there is no uploaded rule #139450

ghost opened this issue Aug 25, 2022 · 7 comments
Assignees
@maximpn
Labels
8.6 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0

Comments

@ghost
Copy link

ghost commented Aug 25, 2022 •
edited by ghost
Loading

Describe the bug
Rules imported successfully when click on import button after cancel the imported rules pop-up with uploaded rule through cross icon and then again open pop-up not having uploaded rule

Build Details

VERSION: 8.5.0-Snapshot
BUILD: 55719
COMMIT: 0212338e4e3ec9db5cfb4e93ad1850a156f0ea9b

Steps

  1. Navigate to Rules Page.
  2. Click on import rules button and upload rule json file.
  3. Click on cross icon to cancel the import file to be uploaded.
  4. Now again click import rules button.
  5. Observe that no uploaded file is shown and still import button is enabled.
  6. Click on import button.
  7. Observe that cancel uploaded rules imported successfully.

Whats Working

  • Issue is only occuring if user click on cross icon to close the modal, if user click on cancel button then the uploaded file doesn't retain behind the scene
Rules.-.not.-.imported.mp4

Screen-Cast

Rules.-.import.rule.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.0 labels Aug 25, 2022
@ghost ghost self-assigned this Aug 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost
Copy link
Author

ghost commented Aug 25, 2022

@karanbirsingh-qasource : Please review the Bug.

@ghost ghost changed the title [Security Solution] Rules imported successfully when click on import button after cancel the imported rules pop-up with uploaded rule through cross icon and then again open pop-up not having uploaded rule [Security Solution] Rules imported successfully when there is no uploaded rule Aug 25, 2022
@ghost ghost assigned banderror and unassigned ghost Aug 25, 2022
@banderror banderror added Team:Detections and Resp Security Detection Response Team Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team and removed triage_needed v8.5.0 labels Aug 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror removed their assignment Aug 25, 2022
@banderror
Copy link
Contributor

@jpdjere this is low impact, but since you will be working on #136758 and #137969 during this cycle, maybe you could look into this one as well. Could be a low-effort fix. I'll add it to our 8.5 scope as "Other" (low priority).

@maximpn
Copy link
Contributor

maximpn commented Nov 3, 2022

@karanbirsingh-qasource @MadameSheema I can't reproduce this bug for 8.6. Could you verify that it's fixed?

@MadameSheema
Copy link
Member

@maximpn you are right! looks like the issue is fixed on latest main branch. Thanks! :)

@sukhwindersingh-qasource
Copy link

Hi @maximpn

We have validated this issue on 8.6.0 BC1 build and observed that issue is Fixed. ✔️

Please find the below Testing Details:

Build info

VERSION: 8.6.0 BC1
BUILD: 58392
COMMIT: 50a7feb0a5eb068d3acccc49c83b9ccb6db6734f

Screen Recording

Rules.-.Kibana.Mozilla.Firefox.2022-11-17.15-20-24.mp4

Hence, We are closing this issue and marking as QA Validated!!

Thanks!!

@sukhwindersingh-qasource sukhwindersingh-qasource added the QA:Validated Issue has been validated by QA label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximpn maximpn

Labels
8.6 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@maximpn @jpdjere @banderror @elasticmachine @MadameSheema @sukhwindersingh-qasource