-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Simplify information shown in the 'Select case' modal #139194
Comments
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
I think putting the search on a separate line makes more sense. @mdefazio What do you think? |
I would suggest removing items first. I don't think we should take up that much vertical real estate with it being on a second line. Being very opinionated about what columns and filters are available in this view would be better IMO. This will then let the search bar grow wider. I agree 'Reporter' and 'Tags' could be good candidates to remove. Also external incident? @cnasikas we discussed some changes to the Cases table that could also apply here. |
Do you believe we should remove the filters also? I think users should have every filter in their disposal to aid them founding the case the need easily. Users may add tags that have a meaning to a case or uniqly identifies the case. Same for the assignees (reporter changed to assigness), the may want to find all cases assigned to them.
They do. It is possible to attach artifacts to a case outside of Security solution or Observability. For example you can attach an ML embendable from the ML page or an OsQuery. The solutions dropdown and column is only visible to applications outside of Security solution or Observability.
We do not support attaching to multiple cases at the moment at the same time. The checkbox/radio would indicate to the user that they can do that, right?
Correct! This is to quickly fix what we already have until we implement the new changes. |
@cnasikas @mdefazio |
I would imagine searching would be more useful for this instance of the table than some of the filters. And so to make that more usable, the trade-off would be to remove (some of) them in favor of a wider search box. I am not suggesting this is also the case for the main Cases table. I'm thinking of this view as a trimmed down version of the cases table. Similar to the experience in github where you can select a label or milestone. Those UI's are minimal with a title and perhaps description. But there are broader views for each that show more information (and search/filter options). Our issue at the moment with this view is readability—so without rethinking how we display the data or provide filters, I think our easiest course is to remove columns/filters to make room for the title and searching as suggested in the issue summary. If we feel all the filters and fields are necessary here, then I would suggest we rethink this UI through mockups first.
Apologies for my previous comment not being clear. I'd like to avoid establishing new variants of our table patterns if possible. What @js-jankisalvi is suggesting feels more akin to our selectable rather than selecting from a table. Let me try and make a quick mockup of some possible options so we can make sure we're thinking the same thing. |
## Summary This PR Fixes: #139194 I Removes below columns and filters from Cases select modal. **Columns** - Tags - Reporters/Assignees - Solution - Comments - Alerts - Updated On - Status - External Incident **Filters** - Reporters/Assignees - Create case button (Create case button will be visible when there are no cases available) **Before** ![image](https://user-images.githubusercontent.com/117571355/216052295-e1788c80-357b-4f38-a2ac-9ce980dbeac9.png) **After:** **Updated** ![image](https://user-images.githubusercontent.com/117571355/216375245-382e58f2-46c6-4c39-b13a-81f439dd5a94.png) ![image](https://user-images.githubusercontent.com/117571355/216375410-f6cbbae7-40c9-4b94-83f4-c756379971a5.png) Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1867 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
The recent work for attaching ML embeddables to new or existing cases in #138994 has highlighted a few usability enhancements that could be made to the 'Select case' modal:
securitySolution
,observability
andcases
. User-friendly labels, as used in the tooltips for the solution icons,Security
,Observability
andStack
, should be used instead.The text was updated successfully, but these errors were encountered: