Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no result style change #138410

Closed
maryam-saeidi opened this issue Aug 9, 2022 · 5 comments · Fixed by #147706
Closed

Fix no result style change #138410

maryam-saeidi opened this issue Aug 9, 2022 · 5 comments · Fixed by #147706
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0

Comments

@maryam-saeidi
Copy link
Member

Kibana version: v 8.4.0-SNAPSHOT

Bug description

When I load the observability alert page, if there is no alert, I see a No result message first without an image and then with the image, and as a result, it seems we are showing 2 different messages despite the fact that both of them are the same.
One possible fix is to have a placeholder for the image to not change the position of content after loading the image. (At the start, I thought we show 2 different no-result messages)

Screenshots

first second
image image

You can check the issue in this screen recording:

Screen-Recording-2022-08-09-at-12.44.46-PM.mp4

Acceptance criteria

  • Fix the No result message style change due to loading the image with a delay
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 labels Aug 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi added the bug Fixes for quality problems that affect the customer experience label Aug 9, 2022
@emma-raffenne
Copy link
Contributor

@maryam-saeidi and @XavierM
This seems to be the "old" alert table. Would the same happen with the shareable one?

@maryam-saeidi
Copy link
Member Author

@emma-raffenne Not sure if it happens in the new table as well or not. Since the No result message Is in the second tab, I cannot easily refresh the page and check the result. Maybe we can keep this bug on hold until we integrate the new alert table and check the result.

@maryam-saeidi
Copy link
Member Author

Btw, I see another issue in the alert table on the rule details page:

image

The message says Try searching over a longer period... but there is no time filter. Does it make sense to use another message here?

@emma-raffenne
Copy link
Contributor

@emma-raffenne Not sure if it happens in the new table as well or not. Since the No result message Is in the second tab, I cannot easily refresh the page and check the result. Maybe we can keep this bug on hold until we integrate the new alert table and check the result.

Makes sense to check once we have integrated the new one. Although, if the "no data" message was going to be changed, we need to take into account the context, i.e. if it's in the rule detail page, it would make no sense to propose to create a new rule for example.

@maryam-saeidi maryam-saeidi self-assigned this Dec 16, 2022
maryam-saeidi added a commit that referenced this issue Dec 20, 2022
…7706)

Fixes #138410

## Summary

I've added image size to avoid a layout shift in the empty state
component. Also added a storybook for that component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants