Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/security_solution/server/lib/detection_engine/rules/bulk_actions - ruleParamsModifier index_patterns should set dataViewId to undefined if overwriteDataViews=true on add_index_patterns action #138409

Closed
kibanamachine opened this issue Aug 9, 2022 · 10 comments · Fixed by #138435
Closed

Failing test: Jest Tests.x-pack/plugins/security_solution/server/lib/detection_engine/rules/bulk_actions - ruleParamsModifier index_patterns should set dataViewId to undefined if overwriteDataViews=true on add_index_patterns action #138409

kibanamachine opened this issue Aug 9, 2022 · 10 comments · Fixed by #138435
Assignees
@banderror
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 9, 2022 •
edited
Loading

A test failed on a tracked branch

Error: expect(received).toHaveProperty(path, value)

Expected path: "dataViewId"

Expected value: undefined
Received value: "test-data-view"
    at Object.<anonymous> (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/rules/bulk_actions/rule_params_modifier.test.ts:126:32)
    at Promise.then.completed (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:212:40)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee89c44c2f212bd5/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 9, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 9, 2022
@kibanamachine kibanamachine added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Aug 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 9, 2022
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@mistic
Copy link
Member

mistic commented Aug 9, 2022

Skipped.

main: 26a4783

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

kibanamachine pushed a commit to e40pud/kibana that referenced this issue Aug 9, 2022
@mistic
skip flaky suite (elastic#138409)
26a4783
@banderror banderror mentioned this issue Aug 9, 2022
Merged
@banderror banderror linked a pull request Aug 9, 2022 that will close this issue
[Security Solution][Detections] Unskip tests for bulk editing index patterns #138435
Merged
@banderror banderror self-assigned this Aug 9, 2022
kibanamachine pushed a commit to JordanSh/kibana that referenced this issue Aug 10, 2022
@banderror
[Security Solution][Detections] Unskip tests for bulk editing index p…
5a24ba3 
…atterns (elastic#138435)

**Ticket:** elastic#138409
**Caused by:** elastic#138304 (comment)

## Summary

The merge of elastic#138304 caused unit tests for bulk editing index patterns to start failing. This PR was reverted by elastic@0bc8cf7. The tests were skipped in elastic@26a4783.

These tests are fully functional in `main`. Unskipping them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banderror banderror

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution][Detections] Unskip tests for bulk editing index patterns banderror/kibana
4 participants
@mistic @banderror @elasticmachine @kibanamachine