Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Auto follower index flyout has a11y violations <dl> items not properly structured #135506

Closed
cuff-links opened this issue Jun 30, 2022 · 2 comments · Fixed by #149069
Closed

[Accessibility] Auto follower index flyout has a11y violations <dl> items not properly structured #135506

cuff-links opened this issue Jun 30, 2022 · 2 comments · Fixed by #149069
Assignees
@ElenaStoeva
Labels
bug Fixes for quality problems that affect the customer experience Feature:CCR and Remote Clusters Project:Accessibility Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cuff-links
Copy link
Contributor

Stack Trace

 
             │ VIOLATION
             │   [definition-list]: Ensures <dl> elements are structured correctly
             │     Impact: serious
             │     Help: https://dequeuniversity.com/rules/axe/4.0/definition-list?application=axeAPI
             │     Elements:
             │       - <dl class="euiDescriptionList euiDescriptionList--row" data-test-subj="settingsValues">
             │ 
             │ VIOLATION
             │   [dlitem]: Ensures <dt> and <dd> elements are contained by a <dl>
             │     Impact: serious
             │     Help: https://dequeuniversity.com/rules/axe/4.0/dlitem?application=axeAPI
             │     Elements:
             │       - <dt class="euiDescriptionList__title">Remote cluster</dt>
             │       - <dd class="euiDescriptionList__description" data-test-subj="remoteCluster">testremote1656554599840</dd>
             │       - <dt class="euiDescriptionList__title">Leader patterns</dt>
             │       - <dd class="euiDescriptionList__description" data-test-subj="leaderIndexPatterns">logstash*</dd>
             │       - <dt class="euiDescriptionList__title">Prefix</dt>
             │       - <dd class="euiDescriptionList__description" data-test-subj="patternPrefix"><em>No prefix</em></dd>
             │       - <dt class="euiDescriptionList__title">Suffix</dt>
             │       - <dd class="euiDescriptionList__description" data-test-subj="patternSuffix"><em>No suffix</em></dd>
             │       at AccessibilityService.assertValidAxeReport (/home/cufflinks/Desktop/workspace/kibana/test/accessibility/services/a11y/a11y.ts:76:13)
             │       at AccessibilityService.testAppSnapshot (/home/cufflinks/Desktop/workspace/kibana/test/accessibility/services/a11y/a11y.ts:49:10)
             │       at runMicrotasks (<anonymous>)
             │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
             │       at Context.<anonymous> (test/accessibility/apps/cross_cluster_replication.ts:88:13)
             │       at Object.apply (/home/cufflinks/Desktop/workspace/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Screenshot 2022-06-29 223705
@cuff-links cuff-links added bug Fixes for quality problems that affect the customer experience Project:Accessibility Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jun 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@ElenaStoeva ElenaStoeva mentioned this issue Jan 17, 2023
Merged
4 tasks
ElenaStoeva added a commit that referenced this issue Jan 18, 2023
@ElenaStoeva @kibanamachine
Fix a11y issues with cross cluster replication flyouts (#149069)
b0deb03 
Fixes #135503, fixes
#135506

## Summary

This PR fixes the a11y issues in the Follower index flyout and the Auto
follower index flyout from the Cross cluster replication plugin.

Screenshots:
<img height="500" alt="Screenshot 2023-01-17 at 17 46 08"
src="https://user-images.githubusercontent.com/59341489/212985332-794a2b7e-3e12-4303-bcbd-ad63552f211c.png">
<img height="500" alt="Screenshot 2023-01-17 at 13 26 51"
src="https://user-images.githubusercontent.com/59341489/212987803-40062d53-3b34-4286-98fc-736264491b08.png">


Followed [these
instructions](https://www.elastic.co/guide/en/elasticsearch/reference/current/ccr-getting-started-tutorial.html#ccr-getting-started-tutorial)
to set up the cross cluster replication and the follower and
auto-follower indices.


### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

Co-authored-by: Kibana Machine <[email protected]>
wayneseymour pushed a commit to wayneseymour/kibana that referenced this issue Jan 19, 2023
@ElenaStoeva @kibanamachine @wayneseymour
Fix a11y issues with cross cluster replication flyouts (elastic#149069)
9fd5b10 
Fixes elastic#135503, fixes
elastic#135506

## Summary

This PR fixes the a11y issues in the Follower index flyout and the Auto
follower index flyout from the Cross cluster replication plugin.

Screenshots:
<img height="500" alt="Screenshot 2023-01-17 at 17 46 08"
src="https://user-images.githubusercontent.com/59341489/212985332-794a2b7e-3e12-4303-bcbd-ad63552f211c.png">
<img height="500" alt="Screenshot 2023-01-17 at 13 26 51"
src="https://user-images.githubusercontent.com/59341489/212987803-40062d53-3b34-4286-98fc-736264491b08.png">


Followed [these
instructions](https://www.elastic.co/guide/en/elasticsearch/reference/current/ccr-getting-started-tutorial.html#ccr-getting-started-tutorial)
to set up the cross cluster replication and the follower and
auto-follower indices.


### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaStoeva ElenaStoeva

Labels
bug Fixes for quality problems that affect the customer experience Feature:CCR and Remote Clusters Project:Accessibility Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a11y issues with cross cluster replication flyouts ElenaStoeva/kibana
3 participants
@cuff-links @elasticmachine @ElenaStoeva