Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Search][Data Views] Allow to search by index pattern too #135235

Open
jughosta opened this issue Jun 27, 2022 · 12 comments
Open

[Unified Search][Data Views] Allow to search by index pattern too #135235

jughosta opened this issue Jun 27, 2022 · 12 comments
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Unified search Unified search related tasks impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@jughosta
Copy link
Contributor

Kibana version: main

Description of the problem including expected versus actual behavior:
Current DataViewPicker allows to filter data views by their name (custom name if provided or index pattern as a fallback). Users might want to be able to search by index pattern field of data views too even if that data view has a custom name.

Steps to reproduce:

  1. Create a data view with a custom name which is different from its index pattern
  2. Try to find that data view by entering index pattern in the search field of DataViewsList

Jun-27-2022 17-26-50

@jughosta jughosta added enhancement New value added to drive a business result Feature:Unified search Unified search related tasks labels Jun 27, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 27, 2022
@jughosta
Copy link
Contributor Author

Linking to #59432

@jughosta
Copy link
Contributor Author

cc @stratoula

@jsanz jsanz added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Jun 27, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 27, 2022
@kertal
Copy link
Member

kertal commented Jun 28, 2022

One more thing we might consider: Allowing also to search by id. While for the generated one this makes no sense, but we also allow to provide custom ids

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@kertal
Copy link
Member

kertal commented Jun 29, 2022

Another reason why we need to do this. When we allow ad-hoc data views, once the user enters a text into the search box, we need to be sure that all possible matches of data view for the given pattern are displayed.

in the current state, when the user would enter indexName and indexName would have a custom name Index Name, nothing would be found and given we search the name of indices that would match, we would suggest to use the entered name for an ad-hoc data view.

@stratoula
Copy link
Contributor

This is easily done with EuiSelectable, we just need to pass a secondary field to search.

Check https://elastic.github.io/eui/#/forms/selectable --> Custom content

@mattkime
Copy link
Contributor

I'd prefer to hear this request from our users. I think this might be a desire to use new functionality in an older way of working. If our users need to identify data views by their underlying index pattern then they can just use the index pattern as the name. I guess I'm skeptical of the need to reference data views in that drop down by BOTH the verbose name and the index pattern.

@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jul 21, 2022
@stratoula
Copy link
Contributor

I see your point here @mattkime and I don't have a strong opinion. I am jus thinking a scenario like:

  • I have x dataviews pointing on the same index pattern but with different names (I am using for example different runtime fields or formatters per dataview)
  • I want to search for the index pattern to find all the dataviews that are related to it (because I don't remember the names or other users have created them.

It could be useful I think! I am fine on waiting the users' feedback too! cc @ghudgins

@kertal
Copy link
Member

kertal commented Aug 3, 2022

In case it's still the plan to allow the user to quickly create a ad-hoc data view, if no matching entry can be found, how would this work without allowing the search for the index pattern?

  • for example a user searches for test-*.
  • This already exists but is labeled TEST.
  • Therefore the user gets no result and a suggestion to search using an ad-hoc data view.

Just wondering how it works without the ability to search by index pattern too ... btw a while ago I saw an old issue requesting a user to search for an id ... because back in the days we had ids like test-*, I'm quite sure the search by index pattern will be requested.

@exalate-issue-sync exalate-issue-sync bot added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Aug 12, 2022
@petrklapka petrklapka added Feature:Search Querying infrastructure in Kibana and removed Team:AppServicesUx labels Nov 23, 2022
@kertal kertal added Feature:Data Views Data Views code and UI - index patterns before 8.0 and removed Feature:Search Querying infrastructure in Kibana labels Jan 9, 2023
@davismcphee davismcphee added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 8, 2023
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kertal kertal removed the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 21, 2024
@kertal
Copy link
Member

kertal commented Oct 21, 2024

wanted to icebox this, but we don't own this area of the code, reassigning. It could be a good issue for somebody starting ... or something to icebox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Unified search Unified search related tasks impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

8 participants