[Dashboard] Add Reset Function to View Mode

[seanbirdsell]

Kibana version: 7.15.1

Elasticsearch version: 7.15.1

Server OS version: unknown

Browser version: Chrome Version 101.0.4951.64 (Official Build) (x86_64)

Browser OS version: MacOS 12.3.1

Original install method (e.g. download page, yum, from source, etc.): unknown

Describe the bug: After opening a saved query in a dashboard, the default filters for the board never return, even after re-loading it.

Steps to reproduce:

1. Open dashboard with existing filters
2. Select a saved query; filters change (expected)
3. Select "Clear" from save query; query removed, filters don't re-appear (expected)
4. Back out to Dashboard selection screen
5. Select dashboard I started with (it should re-load from saved); filters still missing, though saved date range restored (unexpected)
6. Edit dashboard
7. Select "Switch to view mode"; asked to "Discard Changes?" even though no changes were made. Press "Discard Changes" button, filter re-appear
8. Enter query in query bar; filters again disappear

Expected behavior: When a dashboard is re-loaded from the dashboard selection screen, it should open in it's saved state.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context: This error has been reproduced on two different 7.15.1 Kibana servers.

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[stratoula]

The dashboard has a mechanism to remember the users' changes unless they discard them

If you discard them from the dashboard listing page (see my screenshot above) then you will have your dashboard as it was.
I don't think that this is a bug but I think the @elastic/kibana-presentation team can keep me honest here.

[seanbirdsell]

Unfortunately, @stratoula , that message isn't showing up.

[stratoula]

I see, maybe this is a 7.15 presentation behavior. We probably added this to a newer kibana version.

[ThomThomson]

This message actually only shows up in the dashboard when the dashboard is in edit mode. This is a fairly impactful UX issue, and we're working on ways to allow the user to reset their filter state to the last saved mode.

The filtering behaviour between Dashboards, filters from the user's explorations, and Dashboard Controls is a very complicated web at the moment which we need to straighten out.

@stratoula, I'm glad you answered this question, as it's something we'll need to think through with the Unified Search X Controls project.

@seanbirdsell, I will leave this issue open because it's an important thing to track, but there are two ways to work around this issue.

1. Discard changes
   a) Enter Edit mode on the dashboard
   b) hit Switch to View mode and discard changes

2. Close and reopen the tab
   a) Copy the dashboard URL from the top bar of your browser
   b) Close the tab and open a new tab
   c) Paste the URL back in to return to the dashboard

Neither of these workarounds are very good from a UX standpoint, but hopefully this is good enough for the time being, until we can straighten out all of the subtleties surrounding filtering on a dashboard.

[seanbirdsell]

Thanks. This is all great. Appreciate the work.

[ThomThomson]

I've just re-estimated the LOE, with a new idea from an implementation standpoint. We could add a reset function to the dashboard API, which works the same way as edit -> discard changes. Then potentially add a reset button to the top nav in view mode. This would allow users to reset any changes that they have made in view mode to the filters, or the Controls.